Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Slimepeople! (TM For Now) #220

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

Nerev4r
Copy link
Collaborator

@Nerev4r Nerev4r commented Nov 10, 2024

About The Pull Request

Attempts* to port slimepeople.
For the time being, markings are not transparent.

Why It's Good For The Game

Deploying goo!

Changelog

🆑
add: Slimepeople!
/:cl:

Comment on lines 3 to 5
#define DAMAGE_WATER_STACKS 5
/// This is the level of waterstacks that prevent a slimeperson from regenerating, doing minimal bloodloss in the process.
#define REGEN_WATER_STACKS 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define DAMAGE_WATER_STACKS 5
/// This is the level of waterstacks that prevent a slimeperson from regenerating, doing minimal bloodloss in the process.
#define REGEN_WATER_STACKS 1
#define WATER_STACKS_DAMAGING 5
/// This is the level of waterstacks that prevent a slimeperson from regenerating, doing minimal bloodloss in the process.
#define WATER_STACKS_NO_REGEN 1

Just a bit of consistency

if(core_signal)
core_signal.Remove(former_jellyperson)

/obj/item/organ/ears/jelly
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyes?

zone = BODY_ZONE_CHEST
organ_flags = ORGAN_UNREMOVABLE

/obj/item/organ/ears/roundstartslime
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyes?

organ_flags = ORGAN_UNREMOVABLE

/obj/item/organ/brain/slime
name = "core"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "core"
name = "slime core"

Just a little more self evident


/obj/item/organ/brain/slime
name = "core"
desc = "The central core of a slimeperson, technically their 'extract.' Where the cytoplasm, membrane, and organelles come from; perhaps this is also a mitochondria?"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc = "The central core of a slimeperson, technically their 'extract.' Where the cytoplasm, membrane, and organelles come from; perhaps this is also a mitochondria?"
desc = "The central core of a slimeperson, technically their 'extract', and where the cytoplasm, membrane, and organelles come from. Cutting edge research in xenobiology suggests this could also be a mitochondria."

return

user.apply_status_effect(/datum/status_effect/slime_washing)
user.visible_message(span_purple("[user]'s outer membrane starts to develop a roiling film on the outside, absorbing grime into [user.p_their()] inner layer!"), span_purple("Your outer membrane develops a roiling film on the outside, absorbing grime off yourself and your clothes; as well as the floor beneath you."))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
user.visible_message(span_purple("[user]'s outer membrane starts to develop a roiling film on the outside, absorbing grime into [user.p_their()] inner layer!"), span_purple("Your outer membrane develops a roiling film on the outside, absorbing grime off yourself and your clothes; as well as the floor beneath you."))
user.visible_message(span_purple("[user]'s outer membrane starts to develop a cloudy film on the outside, absorbing grime into [user.p_their()] inner layer!"), span_purple("Your outer membrane develops a cloudy film on the outside, absorbing grime off yourself and your clothes; as well as the floor beneath you."))

Bit too flowery IMO

*/
/datum/action/innate/core_signal
name = "Toggle Core Signal"
desc = "Interface with the microchip placed in your core, modifying if it emits a GPS signal or not; due to how thick your liquid body is, the signal won't reach out until your core is outside of it."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc = "Interface with the microchip placed in your core, modifying if it emits a GPS signal or not; due to how thick your liquid body is, the signal won't reach out until your core is outside of it."
desc = "Interface with the microchip placed in your core, modifying whether it emits a GPS signal or not. Due to how thick your liquid body is, the signal won't reach out until your core is outside of it."

if(slime_restricted && !isjellyperson(slime))
return
if(core.gps_active)
to_chat(owner,span_notice("You tune out the electromagnetic signals from your core so they are ignored by GPS receivers upon its rejection."))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably just be a balloon alert

to_chat(owner,span_notice("You tune out the electromagnetic signals from your core so they are ignored by GPS receivers upon its rejection."))
core.gps_active = FALSE
else
to_chat(owner, span_notice("You fine-tune the electromagnetic signals from your core to be picked up by GPS receivers upon its rejection."))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably just be a balloon alert

Comment on lines 35 to 44
/obj/item/bodypart/head/jelly/drop_limb(special, dismembered, move_to_floor = FALSE)
if(special)
return ..()

to_chat(owner, span_warning("Your [name] splatters with an unnerving squelch!"))
playsound(owner, 'sound/effects/blob/blobattack.ogg', 60, TRUE)
owner.blood_volume -= SLIME_LIMB_BLOOD_LOSS
. = ..()
qdel(src)
return .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could definitely be moved into one proc that's then called in each limb

@Nerev4r Nerev4r marked this pull request as ready for review November 15, 2024 19:39
@Nerev4r Nerev4r changed the title Jesus Please Just Stop My Pain ! Adds Slimepeople! (TM For Now) Nov 15, 2024
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Nov 28, 2024
@Nerev4r Nerev4r removed the Stale label Nov 28, 2024
… into nevermindholyshit

# Conflicts:
#	modular_doppler/modular_customization/markings/icons/markings/secondary_markings.dmi
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Dec 12, 2024
@Nerev4r Nerev4r removed the Stale label Dec 12, 2024
… into nevermindholyshit

# Conflicts:
#	code/__DEFINES/~doppler_defines/traits/declarations.dm
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants