Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wifibox hostname in banner #68

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

olijf
Copy link
Contributor

@olijf olijf commented Jun 3, 2016

As you requested: #37
Quite useless, but it was an easy fix.

@olijf olijf mentioned this pull request Jun 3, 2016
@peteruithoven
Copy link
Member

Nice.
A downside is that this happens once, which means people's custom accesspoint name won't show up. Then again I'm not sure this would be possible. The following comment might suggest we could add something to /etc/profile, which would make it dynamic. https://wiki.openwrt.org/doc/howto/snippets#banner_customization
What I don't really like is that it needs to use a rest api endpoint, out of which then needs to be parsed the value, using grep and cut.
Maybe we could create a small lua script that just prints the hostname and try calling that from /etc/profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants