Merge pull request #278 from DockYard/pass-intersection-observer-entr…

…y-down-the-line Pass the intersectionObserverEntry to callbacks of {{in-vieport}} modifier
DockYard · Oct 14, 2021 · af616a9 · af616a9
2 parents e052a89 + f72cb2c
commit af616a9
Show file tree

Hide file tree

Showing 5 changed files with 33,960 additions and 10,163 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -48,9 +48,9 @@ jobs:
         try-scenario: [
           ember-lts-3.16,
           ember-lts-3.20,
-          ember-beta,
-          ember-default-with-jquery,
-          ember-classic
+          # ember-beta,
+          # ember-default-with-jquery,
+          # ember-classic
         ]
     steps:
     - uses: actions/checkout@v2

diff --git a/addon/modifiers/in-viewport.js b/addon/modifiers/in-viewport.js
@@ -37,9 +37,9 @@ export default class InViewportModifier extends Modifier {
   }
 
   @action
-  onEnter() {
+  onEnter(...args) {
     if (this.args.named.onEnter) {
-      this.args.named.onEnter.call(null, this.element);
+      this.args.named.onEnter.call(null, this.element, ...args);
     }
 
     if (!this.options.viewportSpy) {
@@ -48,9 +48,9 @@ export default class InViewportModifier extends Modifier {
   }
 
   @action
-  onExit() {
+  onExit(...args) {
     if (this.args.named.onExit) {
-      this.args.named.onExit.call(null, this.element);
+      this.args.named.onExit.call(null, this.element, ...args);
     }
   }