- Each task - new branch
- DON'T push code into
develop
branch (use PR flow instead) - each task should be completed with Pull Request
Branch name should include task name
-
for new features ---
feature/feature-name
(for examplefeature/add-profile-page
) -
for fixing issue ---
bugfix/bug-name
(for examplebugfix/update-profile-data
)
- go to develop branch.
Basic git flow below (creating new branch from latest develop):
git checkout develop
git pull
git checkout -b feature/feature-name
- Make a few commits
git commit -m 'added table header for charges tab'
git commit -m 'added table body for charges tab'
- Push latest commits to github
git push
- Create PR (see How to create PR flow instructions below)
- go to step 1;
- name should describe latest changes
asd
,blablabla
,fix
-- bad solution for commit nameadded add more button for table
-- good commit name
New pull request
button- select source and target branches
source (branch with your latest commits) right selector
target (general branch) in our case
develop
- left selector Create pull request
big green button in the bottom part- DON'T merge PR
- if PR has conflicts -- you should fix all conflicts for your PR
- add reviewers (at least on from your team)
- select at least one dev from your team and me.
- review section here -> https://prnt.sc/rrwppk
This project was bootstrapped with Create React App.
In the project directory, you can run:
Runs the app in the development mode.
Open http://localhost:3000 to view it in the browser.
The page will reload if you make edits.
You will also see any lint errors in the console.
Launches the test runner in the interactive watch mode.
See the section about running tests for more information.
Builds the app for production to the build
folder.
It correctly bundles React in production mode and optimizes the build for the best performance.
The build is minified and the filenames include the hashes.
Your app is ready to be deployed!
See the section about deployment for more information.
Note: this is a one-way operation. Once you eject
, you can’t go back!
If you aren’t satisfied with the build tool and configuration choices, you can eject
at any time. This command will remove the single build dependency from your project.
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except eject
will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.
You don’t have to ever use eject
. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.
You can learn more in the Create React App documentation.
To learn React, check out the React documentation.
This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting
This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration
This section has moved here: https://facebook.github.io/create-react-app/docs/deployment
This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify