Feat/shu frontend #131
Feat/shu frontend #131
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
package.json
Outdated
| @@ -25,11 +25,12 @@ | |||
| "scripts": { | |||
| "start": "craco start", | |||
| "build": "craco build", | |||
| "build:milkomeda-testnet": "npx -y env-cmd -f ./env/milkomeda-testnet.env npm run build", | |||
| "build:milkomeda-c1-testnet": "npx -y env-cmd -f ./env/milkomeda-testnet.env npm run build", | |||
There was a problem hiding this comment.
Let's get rid of the "c1" here.
There was a problem hiding this comment.
Why did you mark this as resolved, but the "c1" is still there?
There was a problem hiding this comment.
My bad, instead of changing the package.json, I changed the names of ci pipeline to fix build issues. I wasn't aware of the fleek naming convention. I will change it in the next commit.
package.json
Outdated
| "build:sepolia": "npx -y env-cmd -f ./env/sepolia.env npm run build", | ||
| "build:milkomeda": "npx -y env-cmd -f ./env/milkomeda.env npm run build", | ||
| "build:milkomeda-c1": "npx -y env-cmd -f ./env/milkomeda.env npm run build", |
| oracleContract | ||
| ); | ||
| const coinsDetails = isShu | ||
| ? await getShuCoinDetails( |
There was a problem hiding this comment.
Djed and DjedShu are identical in relation to coin details. Do we really need this isShu ? if statement here?
There was a problem hiding this comment.
This comment has not been addressed yet.
There was a problem hiding this comment.
Yes, isShu condition fetches coin details from getShuCoinDetails instead of getCoinDetails and there are considerable differences between the two
|
Preview ready at https://featshu-frontend.djed.codepreview.io
|
There was a problem hiding this comment.
@yogesh0509 , some comments from my previous review remain unaddressed. Everything else is fine.
Note that "c1" comment is important, because Fleek's configuration has been changed and is now not using the "c1" anymore. If I were to merge this PR now, our live deployments for milkomeda in Fleek might stop working.
package.json
Outdated
| @@ -25,11 +25,12 @@ | |||
| "scripts": { | |||
| "start": "craco start", | |||
| "build": "craco build", | |||
| "build:milkomeda-testnet": "npx -y env-cmd -f ./env/milkomeda-testnet.env npm run build", | |||
| "build:milkomeda-c1-testnet": "npx -y env-cmd -f ./env/milkomeda-testnet.env npm run build", | |||
There was a problem hiding this comment.
Why did you mark this as resolved, but the "c1" is still there?
package.json
Outdated
| "build:sepolia": "npx -y env-cmd -f ./env/sepolia.env npm run build", | ||
| "build:milkomeda": "npx -y env-cmd -f ./env/milkomeda.env npm run build", | ||
| "build:milkomeda-c1": "npx -y env-cmd -f ./env/milkomeda.env npm run build", |
| oracleContract | ||
| ); | ||
| const coinsDetails = isShu | ||
| ? await getShuCoinDetails( |
There was a problem hiding this comment.
This comment has not been addressed yet.
|
Preview ready at https://featshu-frontend.djed.codepreview.io
|
No description provided.