-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to host the tutorial project on Glitch.com #1708
Conversation
Update from master origin
Incorporate latest master origin changes
Pull from upstream
Merging latest upstream updates
Hello, We will be relying on these updates for our upcoming public event at CERN https://home.cern/news/announcement/cern/registration-open-online-programming-workshop-django-girls and we would like to translate it also to French, and have it ready for instruction on 8th April to train our 25 coaches. |
Hi @bcopy Cool that you're doing an online Django Girls workshop! (I have myself been involved as coach an later as co-organizer in past Django Girls workshops in Switzerland, though all of them in the German-speaking parts of it. 👋)
That's two week from now. While I hope we can make it until then, please be prepared for the case we won't manage. (The tutorial currently has only few still-active maintainers and all of them work on it only in their free time.) In case the change won't go through till then, you could generate the rendered version of your branch with Honkit and host it yourself (or on GitHub pages or something similar). The most simple approach for that is probably to activate GitHub pages for your fork and adapt the condition tutorial/.github/workflows/deploy.yml Line 10 in 57bba09
|
Concerning putting the Django secret key into a |
Past and current issues and PRs regarding
It looks like the consensus until now was, that having the blatant (but probably not too serious) security issue of publishing the @bcopy Does Glitch.com require that this be handled properly right from the beginning? Can the approach you take be generalized to work with all presented development environment setups, including local development? |
Dear Raphael, Thank you for looking into our PR. Regarding I agree that the tutorial should remain simple and securing concerns can certainly go in an extension.
Yes, in the case of Glitch, the Thank you for your tips concerning regenerating the documentation into our Github Pages, I will apply it. I would like to contribute French translations via Crowdin though - but maybe you also have a suggestion on how we can make some progress without waiting for a merge to master. |
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
The Glitch interface changed slightly.
Co-authored-by: Raphael Das Gupta <[email protected]>
Dear @das-g, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the adaptions and changes. Reading the result again, I've noticed some more things, most of them minor:
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Co-authored-by: Raphael Das Gupta <[email protected]>
Dear @das-g, applied the latest batch of changes, let me know if you can see more corrections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
Merge pull request DjangoGirls#1708 from CERN/master
These changes are now already reflected in the English original on Crowdin, so translation can be done there. |
Changes in this pull request: