chore: modernize module #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be a good idea to migrate the deps to JSR now that it's out. Plug appears to be on there. |
|
@DjDeveloperr what do you think? I need to fix the performance hit on old Deno versions regardless before this gets merged. |
|
I talked to Elias about it - we need some changes in plug before we can migrate: some additional utilities need to be exported, which we can simply import on deno.land/x but on JSR it needs to be explicitly specified as an entry point, or exported from the main entry point. |
|
We could always vendor them, but if you're against that we can just sit tight. |
DjDeveloperr
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63 and #62