Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CADENZA-33335 [Workbook Embedding] Extend folder in navigator #6

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

anistor
Copy link

@anistor anistor commented Oct 3, 2023

  • add highlightGlobalId to CadenzaClient#show and #showMap methods

https://jira.disy.net/browse/CADENZA-33335

@anistor anistor force-pushed the slb/an/CADENZA-33335 branch from 7f29727 to 7fe3a33 Compare October 3, 2023 08:25
@anistor anistor requested a review from Tobias43 October 3, 2023 08:26
src/cadenza.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
sandbox.html Outdated Show resolved Hide resolved
sandbox.html Outdated Show resolved Hide resolved
@anistor anistor force-pushed the slb/an/CADENZA-33335 branch from 7fe3a33 to c237795 Compare October 3, 2023 09:55
@anistor anistor requested review from jkissel and Tobias43 October 3, 2023 09:56
@anistor anistor force-pushed the slb/an/CADENZA-33335 branch from c237795 to c569c27 Compare October 3, 2023 10:08
@anistor
Copy link
Author

anistor commented Oct 3, 2023

I've applied the requested changes, now I believe the reviewer must check them and mark them resolved.

src/cadenza.js Outdated Show resolved Hide resolved
src/cadenza.js Outdated Show resolved Hide resolved
* add highlightGlobalId to CadenzaClient#show and #showMap methods
@anistor anistor force-pushed the slb/an/CADENZA-33335 branch from c569c27 to cd8a3bf Compare October 3, 2023 11:16
@anistor anistor requested a review from Tobias43 October 3, 2023 11:17
@anistor anistor merged commit 9917231 into main Oct 4, 2023
1 check passed
@anistor anistor deleted the slb/an/CADENZA-33335 branch October 4, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants