Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): implement new entitlement endpoint and parameter #1250

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Snipy7374
Copy link
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 added t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation t: enhancement New feature labels Nov 24, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since Client.entitlements is also new in 2.10, the addition of exclude_deleted in the same version doesn't have to be mentioned here.

It would be awesome if you could merge the Client.fetch_entitlement part with the other two changelog fragments for entitlements (1113 + 1186), such that all entitlement changes are grouped in the final changelog.
For instance, 1113.feature.rst and 1186.feature.rst already have the same content, so towncrier shows them as one entry with both PR numbers1:
image

Footnotes

  1. (this feature is a bit weird, but that's just how towncrier works; let me know if anything's confusing)

disnake/client.py Outdated Show resolved Hide resolved
disnake/http.py Outdated Show resolved Hide resolved
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@shiftinv
Copy link
Member

Looks like the new exclude_deleted parameter defaults to true (unlike exclude_ended), we should reflect that here as well: discord/discord-api-docs@e6ac32c#diff-82a22117a97948da6ec935f7b23f3bec7a1d6b4cef7119bb5610d92b95fbeb86R76

@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement new entitlement endpoint
2 participants