-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): implement new entitlement endpoint and parameter #1250
base: master
Are you sure you want to change the base?
Conversation
changelog/1249.feature.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since Client.entitlements
is also new in 2.10, the addition of exclude_deleted
in the same version doesn't have to be mentioned here.
It would be awesome if you could merge the Client.fetch_entitlement
part with the other two changelog fragments for entitlements (1113 + 1186), such that all entitlement changes are grouped in the final changelog.
For instance, 1113.feature.rst
and 1186.feature.rst
already have the same content, so towncrier shows them as one entry with both PR numbers1:
Footnotes
-
(this feature is a bit weird, but that's just how towncrier works; let me know if anything's confusing) ↩
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Looks like the new |
… feat/entitlements
… feat/entitlements
Summary
Checklist
pdm lint
pdm pyright