-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commands): Add support for Range[LargeInt, ...]
#1201
Open
Enegg
wants to merge
10
commits into
DisnakeDev:master
Choose a base branch
from
Enegg:Eneg/large-range
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enegg
changed the title
Add support for
feat(commands): Add support for Jun 2, 2024
Range[LargeInt, ...]
Range[LargeInt, ...]
8 tasks
Tangentially related: we could add slice support for defining ranges ( |
Enegg
commented
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #787
This PR adds support for defining a range of accepted values for
commands.LargeInt
.If both bounds are specified, we restrict the length of the string input according to the number of digits (and sign) of the bounds.
We also raise an error during conversion, if the provided value would exceed the defined range (for example
Range[LargeInt, 100, 200]
would have actual possible input of 100-999).I've also implemented a check in case the developer attempts to define a range exceeding ±2**53 with the normal
int
type, directing them toLargeInt
.Checklist
pdm lint
pdm pyright