Skip to content

Update Rust crate serde to 1.0.192 #218

Update Rust crate serde to 1.0.192

Update Rust crate serde to 1.0.192 #218

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy succeeded Nov 7, 2023 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.75.0-nightly (189d6c71f 2023-11-06)
  • cargo 1.75.0-nightly (65e297d1e 2023-11-03)
  • clippy 0.1.75 (189d6c7 2023-11-06)

Annotations

Check warning on line 108 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression borrows a value the compiler would automatically borrow

warning: this expression borrows a value the compiler would automatically borrow
   --> src/main.rs:108:28
    |
108 |         match_name != "show" && !(&(actions)[&match_name_yaml]["args"].is_null()).to_owned();
    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(actions)[&match_name_yaml]["args"].is_null()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 99 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

binary comparison to literal `Option::None`

warning: binary comparison to literal `Option::None`
  --> src/main.rs:99:5
   |
99 |     if matches.subcommand() == None {
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `matches.subcommand().is_none()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
   = note: `#[warn(clippy::partialeq_to_none)]` on by default

Check warning on line 83 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the loop variable `j` is only used to index `args_vec`

warning: the loop variable `j` is only used to index `args_vec`
  --> src/main.rs:83:14
   |
83 |                 for j in 0..args_vec.len() {
   |                          ^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
   = note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
   |
83 |                 for <item> in &args_vec {
   |                     ~~~~~~    ~~~~~~~~~

Check warning on line 69 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `linked_hash_map::Values<'_, yaml_rust::Yaml, yaml_rust::Yaml>`

warning: useless conversion to the same type: `linked_hash_map::Values<'_, yaml_rust::Yaml, yaml_rust::Yaml>`
  --> src/main.rs:67:48
   |
67 |       let values: Vec<&LinkedHashMap<Yaml, Yaml>> = actions
   |  ___________________________________________________^
68 | |         .values()
69 | |         .into_iter()
   | |____________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing `.into_iter()`
   |
67 ~     let values: Vec<&LinkedHashMap<Yaml, Yaml>> = actions
68 ~         .values()
   |

Check warning on line 64 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `linked_hash_map::Keys<'_, yaml_rust::Yaml, yaml_rust::Yaml>`

warning: useless conversion to the same type: `linked_hash_map::Keys<'_, yaml_rust::Yaml, yaml_rust::Yaml>`
  --> src/main.rs:62:24
   |
62 |       let keys: Vec<&str> = actions
   |  ___________________________^
63 | |         .keys()
64 | |         .into_iter()
   | |____________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
   |
62 ~     let keys: Vec<&str> = actions
63 ~         .keys()
   |

Check warning on line 2 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

found module declaration for lib.rs

warning: found module declaration for lib.rs
 --> src/main.rs:2:1
  |
2 | mod lib;
  | ^^^^^^^^
  |
  = note: lib.rs is the root of this crate's library target
  = help: to refer to it from other targets, use the library's name as the path
  = note: `#[warn(special_module_name)]` on by default