Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to use #[component] instead of #[inline_props] #118

Closed
wants to merge 3 commits into from

Conversation

tigerros
Copy link

@tigerros tigerros commented Sep 14, 2023

This updates docs to reflect changes in DioxusLabs/dioxus#1448.

  • Update docs to use #[component] instead of #[inline_props].
  • Remove #![allow(non_snake_case)] when unnecessary because of #[component].
  • Add #[component] to components that don't have it.
  • Fix some typos.

The changes don't apply to posts/ and release notes. There might be mistakes (given the extremely broad scope of this), but I tried to check each file manually to adjust other factors instead of just globally replacing inline_props with component. For example, "...#[inline_props] allows you to..." should be "...#[component] also allows you to...", in reference to the fact that all components already use #[component].

The Dioxus versions also need to be updated, but I'm not sure what version will DioxusLabs/dioxus#1448 release in (which is a prerequisite to this being merged).

@tigerros
Copy link
Author

To clarify, the checks are failing because the Dioxus version is still at 0.4.0, which obviously doesn't have the #[component] macro. That's why this is a draft PR. I'm waiting until DioxusLabs/dioxus#1448 gets published in 0.4.x and then I'll update this.

@ealmloff ealmloff added the documentation Improvements or additions to documentation label Sep 14, 2023
@ealmloff
Copy link
Member

This was fixed in 19d8a5e

@ealmloff ealmloff closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants