Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiP] Export results #66

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[WiP] Export results #66

wants to merge 16 commits into from

Conversation

phibos
Copy link
Member

@phibos phibos commented Apr 7, 2017 •
edited
Loading

Issue type
  • Feature
Summary

Add experimental support to export the result data in different file formats.

@phibos phibos added this to the 0.5 milestone Apr 7, 2017
@phibos phibos self-assigned this Apr 7, 2017
@coveralls
Copy link

coveralls commented Apr 7, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-7.2%) to 87.416% when pulling d3e8cc2 on export into db8f80e on master.

@coveralls
Copy link

coveralls commented Apr 7, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-2.5%) to 92.152% when pulling bd77653 on export into db8f80e on master.

@matkoniecz
Copy link

@DinoTools

What is your opinion/plan about this PR? What is blocking potential merging?

I am asking as this feature would be useful for my purposes.

@phibos phibos removed this from the 0.5 milestone Apr 14, 2021
@phibos
Copy link
Member Author

phibos commented Apr 22, 2021

Tests are still successful. There are only a few minor style issues. Will finish work on PR #98 and then try to merge this one.

@phibos phibos added this to the 0.7 milestone Apr 22, 2021
rowanwins
rowanwins reviewed Apr 29, 2021
View reviewed changes
overpy/format/geojson.py
for way in result.ways:
properties = {}
coordinates = []
for node in way.nodes:
Copy link

@rowanwins rowanwins Apr 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this excellent PR!
Just one brief suggestion - Some way's have duplicate first and last coordinates and so they ought to be treated as Polygon rather than LineString.
For more info check out https://wiki.openstreetmap.org/wiki/Way#Types_of_way
and
https://wiki.openstreetmap.org/wiki/Overpass_turbo/Polygon_Features (this info feels a bit more interpretable)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the information. I will have a look at the documentation.

phibos added 15 commits April 29, 2021 21:29
@phibos phibos removed this from the 0.7 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanwins rowanwins rowanwins left review comments

Assignees

@phibos phibos

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phibos @coveralls @matkoniecz @rowanwins