Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to react version with source maps #34

Closed
wants to merge 2 commits into from
Closed

upgrade to react version with source maps #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e5c09
upgrade react in benchmark
jantimon Nov 21, 2023
7e26d16
log errors to test source maps
jantimon Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/benchmark/codspeed/index.bench.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ import { KanjiLetterComponentStyled } from "../letters/KanjiLetterComponent.styl
renderToString(<KanjiLetterComponentYak />).length;
})
.on("cycle", function (event: Benchmark.Event) {
if ("error" in event.target) {
console.error(event.target.error);
}
console.log(String(event.target));
});

Expand Down
8 changes: 4 additions & 4 deletions packages/benchmark/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
"lighthouse": "node ./lighthouse/lighthouse.mjs",
"codspeed": "pnpm run codspeed:build && pnpm run codspeed:run",
"codspeed:build": "tsup ./codspeed/index.bench.tsx --sourcemap inline --format esm --target node20 --clean --outDir ./codspeed/dist --external benchmark --external react --external next-yak --external styled-components --external react-dom --external @codspeed/benchmark.js-plugin",
"codspeed:run": "NODE_ENV=production node ./codspeed/dist/index.bench.mjs"
"codspeed:run": "NODE_ENV=production node --enable-source-maps ./codspeed/dist/index.bench.mjs"
},
"dependencies": {
"next": "canary",
"react": "18.2.0",
"react-dom": "18.2.0",
"next": "14.0.3",
"react": "18.3.0-canary-bbb9cb116-20231117",
"react-dom": "18.3.0-canary-bbb9cb116-20231117",
"next-yak": "workspace:*",
"styled-components": "6.1.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@types/node": "20.4.5",
"@types/react": "18.2.28",
"@types/react-dom": "18.2.7",
"next": "14.0.0",
"next": "14.0.3",
"react": "18.2.0",
"react-dom": "18.2.0",
"typescript": "5.1.6",
Expand Down
Loading
Loading