allow unquoted urls #227
Merged
allow unquoted urls #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 085c907 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #227 will not alter performanceComparing Summary
|
|
Would it make sense to add a fixture case for the bug that is addressed? |
jantimon
force-pushed
the
fix/unquoted-urls
branch
from
edf1409 to
c1ed962
Compare
Mad-Kat
previously approved these changes
Dec 4, 2024
Co-authored-by: Luca Schneider <[email protected]>
Mad-Kat
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, the CSS parser would incorrectly interpret special characters (like colons) inside unquoted CSS function values as syntax separators. This caused the parser to break when encountering valid CSS like:
this fix adds parenthesis depth tracking to properly handle all CSS function values (url, calc, rgb, etc.) regardless of whether they are quoted
Fixes #226