Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore empty class names #141

Merged
merged 1 commit into from
Jul 23, 2024
Merged

ignore empty class names #141

merged 1 commit into from
Jul 23, 2024

Conversation

jantimon
Copy link
Collaborator

this improvement helps with snapshot results

Copy link

codspeed-hq bot commented Jul 23, 2024

CodSpeed Performance Report

Merging #141 will not alter performance

Comparing feature/empty-class-names (98f985b) with main (d621ac1)

Summary

✅ 2 untouched benchmarks

@jantimon jantimon requested a review from Mad-Kat July 23, 2024 05:21
/>
`);
<h1
style={{}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do the same with empty styles?

Copy link
Collaborator Author

@jantimon jantimon Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this would be more expensive but especially for testing useful 👍

maybe in mocks?

@jantimon jantimon merged commit 5a4042d into main Jul 23, 2024
5 checks passed
@jantimon jantimon deleted the feature/empty-class-names branch July 23, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants