Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info and assess icon to area card #15

Merged
merged 10 commits into from
Aug 13, 2024

Conversation

NingyueZhou
Copy link
Contributor

@NingyueZhou NingyueZhou commented Aug 8, 2024

Not logged in:
image

Logged in:
image

Because the artifact card size increased by adding icons, the area card size also increased, no overlapped icons and text in area card.
image

@NingyueZhou NingyueZhou self-assigned this Aug 8, 2024
@NingyueZhou NingyueZhou marked this pull request as ready for review August 11, 2024 19:32
@NingyueZhou NingyueZhou requested review from mourabitiziyad and severynenko and removed request for mourabitiziyad August 11, 2024 19:32
@severynenko
Copy link
Contributor

Maybe we could still have icons on the top right for consistency and fix the overlapping by removing/fixing hide functionality?

Copy link
Contributor

@severynenko severynenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! The only thing, I would move icons to the top right corner after the hover is fixed. It would allow us to see what it looks like there and choose

@severynenko
Copy link
Contributor

Area view:
Screenshot 2024-08-13 at 17 02 22
Area view with area hidden:
Screenshot 2024-08-13 at 17 02 56
Artefact view:
Screenshot 2024-08-13 at 17 03 08

@severynenko severynenko merged commit f540ab1 into main Aug 13, 2024
0 of 3 checks passed
@severynenko severynenko deleted the page/refa-artefact-add-assess-icon-and-sheet branch August 13, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants