Adds support for SMEMBERS.WATCH command #1289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for adding support for SMEMBERS.WATCH command @superiorsd10! Had a few small comments.
internal/eval/store_eval.go
Outdated
There was a problem hiding this comment.
Could you reformat this file? I'm seeing additional diffs here due to indentation changes which makes it harder to see the actual code changes.
| }) | ||
| } | ||
|
|
||
| func sortSlice(v any) any { |
There was a problem hiding this comment.
Do we really need to use sortSlice? I think we may be able to use testify library's assert.ElementsMatch method
JyotinderSingh
requested changes
Nov 17, 2024
|
Hi @superiorsd10 , Please rebase the PR with latest master, Thanks. |
superiorsd10
force-pushed
the
smembers-watch
branch
from
a42d0e1 to
cc9989e
Compare
|
@apoorvyadav1111 I've rebased it with the latest master. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature described in the issue #1132. The new
SMEMBERS.WATCHcommand allows subscribed clients to receive push responses whenever the data in a respective set is modified.Changed Introduced
evalSADDfunctionSMEMBERS.WATCHWhy did I modified the
evalSADDfunctionI have had to modify this function because the subscribers were receiving double notifications for the first
SADDcommand. The old implementation caused double notifications because it performed astore.PUTfor the initial set creation and subsequent additions. The new implementation defers thestore.PUToperation until all additions are complete, ensuring subscribers are notified only once.Why Sorting the Results in Integration Tests Is Necessary
To validate the correctness of the reactive system, we care about the contents and not the order of the set. Sorting both the expected and received results allows us to
Screenshot