Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Submit Issue on GitHub" Button in Playground Header #83

Merged

Conversation

MehulKChaudhari
Copy link
Contributor

@MehulKChaudhari MehulKChaudhari commented Dec 12, 2024

Changes

  • New Feature: Added a Submit Issue on GitHub button in the header for easier access to issue reporting.

  • Testing: Added tests to check the functionality of the new button.

  • CSS Improvements: Fixed alignment of the logo and text in the GitHub (4k) star button.

Screenshots

Screenshot 2024-12-13 at 3 08 13 AM Screenshot 2024-12-13 at 3 09 36 AM

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for dicedb-playground ready!

Name Link
🔨 Latest commit 717fbb4
🔍 Latest deploy log https://app.netlify.com/sites/dicedb-playground/deploys/67610e9074daf20009c942f5
😎 Deploy Preview https://deploy-preview-83--dicedb-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@ayushsatyam146 ayushsatyam146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MehulKChaudhari
Copy link
Contributor Author

Just curious, Why are we removing the Footer?

I mean it looks good and it's relevant.

@lucifercr07

image

@lucifercr07
Copy link
Contributor

Just curious, Why are we removing the Footer?

I mean it looks good and it's relevant.

@lucifercr07

We decided to keep the UI clean hence have removed the footer for now, also it wasn't in parity with our dicedb.io site footer.

@lucifercr07 lucifercr07 merged commit fa7e0b4 into DiceDB:master Dec 17, 2024
5 checks passed
@MehulKChaudhari
Copy link
Contributor Author

Just curious, Why are we removing the Footer?
I mean it looks good and it's relevant.
@lucifercr07

We decided to keep the UI clean hence have removed the footer for now, also it wasn't in parity with our dicedb.io site footer.

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants