Adding new design+new download functionality #13
Conversation
|
@lucifercr07 can you review |
| <div className="border rounded-lg p-4"> | ||
| <h2 className="text-xl font-semibold mb-4">Recent Commands</h2> | ||
| <ul className="space-y-2 border"> | ||
| {['SELECT * FROM users', 'INSERT INTO products', 'UPDATE orders SET status = "shipped"'].map((cmd, index) => ( |
There was a problem hiding this comment.
We can use the browser session to populate recently run commands. I've just kept a placeholder array for now. Do you think this feature is worth implementing?
There was a problem hiding this comment.
For now I'm not sure, let's create an issue out of it and we can pick this up later after we go live.
| import Cli from "@/components/CLI/CLI"; | ||
| import SearchBox from "@/components/Search/SearchBox"; | ||
| import { Dice1, Dice3, Dice5 } from "lucide-react"; | ||
| import { Dice1, Dice3, Dice5, Clock, Command, Sun, Moon, Github, Download } from "lucide-react"; |
There was a problem hiding this comment.
Let's remove the download functionality for now, please open an issue for this we can pick up later.
|
|
||
|
|
||
| const NavBar: React.FC<{ isDarkMode: boolean; toggleDarkMode: () => void }> = ({ isDarkMode, toggleDarkMode }) => ( |
There was a problem hiding this comment.
We want to keep things in parity with our website dicedb.io, please open an issue for DarkMode we can take this up later.
|
@saiphanindra1010 thanks a lot for your contribution. I'd suggest let's just limit the scope of this PR to Cleanup and Commands left for now. Also please contribute test cases for components, may be as a separate PR, we're eagerly looking for that. |
|
@lucifercr07 do I close pr I see one more pr which is fixing ui |
|
@saiphanindra1010 we can keep your header changes and cleanup timer, commands left changes. Rest we can create an issue and fix. |
|
@lucifercr07 done removed download and hardcoded data
|
|
@saiphanindra1010 recent commands is also not required for now I believe. We can add these functionalities later. Also as mentioned in above comment please align docs, blog etc. in header to be in parity with dicedb.io website. |
|
@lucifercr07 All the links are pointing to the correct links and reverted the commends |
We need to keep title as DiceDB Playground itself and align other blogs etc. in same header. Try to replicate like below if possible |
|
@lucifercr07 in lucid-react brand icons are deprecated do I use a different package? |
|
this is how it looks without logos cc @lucifercr07 |
|
@saiphanindra1010 please fix the merge conflicts. |
Added new features and improvements:
Before:
After:
