Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Contributor #76

Merged
merged 2 commits into from
Mar 13, 2021
Merged

Added Contributor #76

merged 2 commits into from
Mar 13, 2021

Conversation

rohan-kulkarni-25
Copy link
Contributor

Fixes #69

@DhairyaBahl DhairyaBahl self-requested a review March 13, 2021 11:09
DhairyaBahl
DhairyaBahl requested changes Mar 13, 2021
View reviewed changes
Copy link
Owner

@DhairyaBahl DhairyaBahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do add yourself in the contributors.md list

@rohan-kulkarni-25
Copy link
Contributor Author

Do add yourself in the contributors.md list

Dont worry it is automated will get added after this pull request gets merged :)

@DhairyaBahl
Copy link
Owner

@rohank2502 I am talking about the contributors.md file in which you have to add yourself manually !

@rohan-kulkarni-25
Copy link
Contributor Author

@rohank2502 I am talking about the contributors.md file in which you have to add yourself manually !

Oo Sorry I will So it now just a min !!

@rohan-kulkarni-25
Copy link
Contributor Author

Done !!

@DhairyaBahl DhairyaBahl merged commit 4f55ef2 into DhairyaBahl:master Mar 13, 2021
@DhairyaBahl DhairyaBahl added GSSoC21 Mandatory Tag Level1 Major Documentation labels Mar 13, 2021
@DhairyaBahl
Copy link
Owner

@rohank2502 Merged ! Thank you for the contribution 🔥

@rohan-kulkarni-25
Copy link
Contributor Author

rohan-kulkarni-25 commented Mar 13, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhairyaBahl DhairyaBahl DhairyaBahl requested changes

Assignees
No one assigned
Labels
GSSoC21 Mandatory Tag Level1 Major Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Contributor section in readme ( Automatically )
2 participants
@rohan-kulkarni-25 @DhairyaBahl