Porting to new API 3 #172

AnastaZIuk · 2021-08-05T22:53:20Z

@Erfan-Ahmadi we can continue our work here

…rectly (needs testing)

AnastaZIuk · 2021-08-05T22:56:36Z

AnastaZIuk · 2021-08-05T22:58:00Z

@sadiuk what is the status?

sadiuk · 2021-08-06T08:05:37Z

@sadiuk what is the status?

@AnastaZIuk according to #166 (comment) obj Loader, png and jpeg writers and loaders are tested, also shader loading was fixed when i was doing ex6, but i'm about to start that CWD work, so it'll most likely need a rework and a new round of testing.

AnastaZIuk · 2021-08-06T12:59:42Z

@sadiuk what is the status?

@AnastaZIuk according to #166 (comment) obj Loader, png and jpeg writers and loaders are tested, also shader loading was fixed when i was doing ex6, but i'm about to start that CWD work, so it'll most likely need a rework and a new round of testing.

very nice

AnastaZIuk · 2021-08-07T17:02:12Z

@sadiuk perhaps found a new bug for you to fix, there is something definitely wrong with getting shader assets, I think I get infinite loop when trying to execute this one https://github.com/Devsh-Graphics-Programming/Nabla/blob/examplesPort/examples_tests/09.ColorSpaceTest/main.cpp#L86

…a implementation). I need to check built-in glsl headers as well, they probably has changed!

AnastaZIuk · 2021-08-07T18:26:44Z

added #15 (comment)

AnastaZIuk · 2021-08-07T18:34:16Z

TODO: add camera header after @Erfan-Ahmadi adjusts to following Matt's review c20e00c

sadiuk · 2021-08-09T08:26:16Z

@sadiuk perhaps found a new bug for you to fix, there is something definitely wrong with getting shader assets, I think I get infinite loop when trying to execute this one https://github.com/Devsh-Graphics-Programming/Nabla/blob/examplesPort/examples_tests/09.ColorSpaceTest/main.cpp#L86

@AnastaZIuk fixed that. Tag me if (or rather when XD) you find more bugs.

devshgraphicsprogramming · 2021-08-09T09:28:03Z

you guys should merge the latest input_channel_demo which includes C++20

AnastaZIuk · 2021-08-09T16:07:51Z

TODO: https://github.com/cloudygeek/baw_Game/commit/a911eba8acf29d65e30f60548d756ad21a322a2d#r54624190

…ramming/Nabla into examplesPort

…bla.h.in

AnastaZIuk · 2021-08-11T10:36:22Z

that one is curious @sadiuk

seems like something is wrong when destroying objects after returning from main?

…isplaying the scene

AnastaZIuk · 2021-08-11T13:24:37Z

@Erfan-Ahmadi you can use QToQuitEventReceiver.h in your examples to leave the hot loop by the way

…s_port Erfan examples port

…. example. TODO: launch it and test it

…geometry creator probably, most of objects are drawn wrong.

AnastaZIuk · 2021-08-11T16:41:22Z

TODO: GeometryCreator bugs, only 2 of 9 get displayed, and they are displayed wrong, the geometry is screwed!

AnastaZIuk · 2021-08-14T14:25:41Z

@sadiuk GLI writer doesn't work at all, dds files have 0 bytes

AnastaZIuk · 2021-08-14T14:28:18Z

and what is that? I get this each time

AnastaZIuk · 2021-08-14T14:40:52Z

@sadiuk GLI writer doesn't work at all, dds files have 0 bytes

fixed

AnastaZIuk · 2021-08-14T15:06:32Z

@sadiuk also there is something wrong with GLI loader, it doesn't load some ktx files, it returns empty assets

fixed

… synchronization chad-like, correct pointer const qualifiers in IGPUObjectFromAssetConverter

AnastaZIuk · 2021-08-14T19:36:47Z

that one is curious @sadiuk

seems like something is wrong when destroying objects after returning from main?

okay I found that it is probably a bug for @Crisspl
something is wrong with destroyGlObjects

…example work, remove cpu2gpu params from CommonAPI - it must not be there

AnastaZIuk · 2021-08-15T21:07:44Z

@devshgraphicsprogramming changed the base of PR, ready for you

devshgraphicsprogramming · 2021-08-16T12:14:04Z

did you test all the samples which are supposed to work so far (previously ported) ?

AnastaZIuk · 2021-08-16T12:16:15Z

did you test all the samples which are supposed to work so far (previously ported) ?

yes, they work but because of changes I need to test and adjust compute shaders sample and megatexture sample

devshgraphicsprogramming · 2021-08-16T12:16:26Z

examples_tests/35.GeometryCreator/main.cpp

+	auto updateCpu2GpuSignalizatorsWithPureObjects = [&]() -> void //! reset the state by creating new gpu objects after cpu2gpu conversion
+	{
+		gpuTransferFence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
+		gpuTransferSemaphore = logicalDevice->createSemaphore();
+
+		gpuComputeFence = logicalDevice->createFence(static_cast<video::IGPUFence::E_CREATE_FLAGS>(0));
+		gpuComputeSemaphore = logicalDevice->createSemaphore();
+	};


same question as before

what do you mean?

this sample works

ok, GitHub failed me again

didn't we solve the fence thing last week?

Also you can reuse semaphores just fine, you just need each signal and wait to come in pairs and always happen (signal must be consumed).

like we shouldn't need to create fresh fences anymore, just use the same one for all transfers and await at the end after the last and manual submit.

ok, GitHub failed me again

didn't we solve the fence thing last week?

Also you can reuse semaphores just fine, you just need each signal and wait to come in pairs and always happen (signal must be consumed).

yeah we did it, actually I should use those semaphoes, fences because they do nothing at all (I should use their signalized state for some wait)

…sualStudio merge tool)

…ystem TODO), add byteswap utility

devshgraphicsprogramming · 2021-08-17T19:42:09Z

include/nbl/core/Byteswap.h

+	class Byteswap
+	{
+		Byteswap() = delete;
+	public:
+
+		#if defined(_NBL_WINDOWS_API_) && defined(_MSC_VER) && (_MSC_VER > 1298)
+		#include <stdlib.h>
+		#define bswap_16(X) _byteswap_ushort(X)
+		#define bswap_32(X) _byteswap_ulong(X)
+		#elif defined(_NBL_OSX_PLATFORM_)
+		#include <libkern/OSByteOrder.h>
+		#define bswap_16(X) OSReadSwapInt16(&X,0)
+		#define bswap_32(X) OSReadSwapInt32(&X,0)
+		#elif defined(__FreeBSD__) || defined(__OpenBSD__)
+		#include <sys/endian.h>
+		#define bswap_16(X) bswap16(X)
+		#define bswap_32(X) bswap32(X)
+		#else
+		#define bswap_16(X) ((((X)&0xFF) << 8) | (((X)&0xFF00) >> 8))
+		#define bswap_32(X) ( (((X)&0x000000FF)<<24) | (((X)&0xFF000000) >> 24) | (((X)&0x0000FF00) << 8) | (((X) &0x00FF0000) >> 8))
+		#endif
+
+		template<typename NUM_TYPE>
+		static inline NUM_TYPE byteswap(NUM_TYPE number)
+		{
+			if constexpr (std::is_same<NUM_TYPE, int8_t>::value)
+				return number;
+			else if (std::is_same<NUM_TYPE, uint8_t>::value)
+				return number;
+			else if (std::is_same<NUM_TYPE, uint16_t>::value)
+				return bswap_16(number);
+			else if (std::is_same<NUM_TYPE, int16_t>::value)
+				return bswap_16(number);
+			else if (std::is_same<NUM_TYPE, uint32_t>::value)
+				return bswap_32(number);
+			else if (std::is_same<NUM_TYPE, int32_t>::value)
+				return bswap_32(number);
+			else if (std::is_same<NUM_TYPE, float>::value)
+			{
+				uint32_t value = core::IR(number);
+				value = bswap_32(value); 
+				return core::FR(value);
+			}
+			else
+				static_assert(false, "there are not another supported types!");
+		}
+	};


I f***ing hate this class/implementation, can you find something cleaner online using C++11 or C++20 that doesnt do this macro fuckery?

also should be a free floating function, not some weird class

wtf is #include stdlib.h inside class definition XD

wtf is #include stdlib.h inside class definition XD

XD

copy paste magic

…some dependencies. Either changing input file and adding cmake definitions works.

…template from byteswap class, change contextes

…t for supporting virtual files input (NEEEDS TESTING!)

… to begin with 0 index resource

Port colorspacetest example & FullScreenTriangle.h, make it build cor…

f63c69e

…rectly (needs testing)

sadiuk and others added 2 commits August 6, 2021 18:31

IWindow::setCaption()

e85874b

Add caption data for ColorSpaceTest example

7f0f319

Add compile-able computeShaders example (waiting for events and camer…

b98e50f

…a implementation). I need to check built-in glsl headers as well, they probably has changed!

fixed a bug Arek had with glsl loading

9c9d053

Erfan-Ahmadi and others added 4 commits August 10, 2021 23:39

Camera.hpp moved

b3611d9

Merge Erfan

a2ed7fc

Merge branch 'examplesPort' of https://github.com/Devsh-Graphics-Prog…

9821f52

…ramming/Nabla into examplesPort

Add events & camera to 06. example, remove wrong header in include/na…

92fba35

…bla.h.in

AnastaZIuk added 3 commits August 11, 2021 12:37

Port previous QToQuitEventReceiver.h

52da92d

correct viewport depth fuck-up, there is still something wrong with d…

c94757d

…isplaying the scene

Damn I din't have DepthBuffer at all

c16900e

devshgraphicsprogramming and others added 2 commits August 11, 2021 16:37

Merge pull request #174 from Devsh-Graphics-Programming/erfan_example…

6a787c5

…s_port Erfan examples port

Add camera, event handling, command submitting and depth buffer to 53…

b78b5e9

…. example. TODO: launch it and test it

AnastaZIuk changed the title ~~Porting Examples to new API 3~~ Porting to new API 3 Aug 11, 2021

Fix bindIndexBuffer, port 35. example. There is something buggy with …

d504acc

…geometry creator probably, most of objects are drawn wrong.

reverse depth fix

717177b

Fix GLI Writer

79e9708

Fix wrong KTX magic number bug

bd1da7d

Finally use more command buffers and fbos, acquire images and be more…

3786746

… synchronization chad-like, correct pointer const qualifiers in IGPUObjectFromAssetConverter

AnastaZIuk added 3 commits August 14, 2021 21:39

Fix a lot of bugs, poll events before reseting fence

42d3287

Fix resourceIx bug, correct some examples and make derivativeMapTest …

d30aedc

…example work, remove cpu2gpu params from CommonAPI - it must not be there

Resolve conflicts, merge the Matt's branch

25e4a39

AnastaZIuk changed the base branch from criss_android to apis_as_plugins August 15, 2021 21:06

devshgraphicsprogramming reviewed Aug 16, 2021

View reviewed changes

AnastaZIuk added 4 commits August 17, 2021 16:06

Port 27 STL and PLY example, merge went wrong and need to fix it

d04e489

Correct wrong COpenGL_Swapchain.h merge (it was my first time with Vi…

56551f8

…sualStudio merge tool)

Add opportunity for compiling Nabla with STL/PLY loaders again (Files…

a85561f

…ystem TODO), add byteswap utility

Port PLY mesh loader (TODO: perform a test)

60bbcf6

devshgraphicsprogramming reviewed Aug 17, 2021

View reviewed changes

Base automatically changed from apis_as_plugins to property_pool August 18, 2021 14:44

AnastaZIuk added 6 commits August 18, 2021 17:05

Port STL loader (needs testing)

fb1934a

Port STL writer (needs testing)

1aa838e

Like a boss! Generete nabla.h at build time with separate target and …

1036138

…some dependencies. Either changing input file and adding cmake definitions works.

Port PLY writer (needs testing) and make Nabla compile again, remove …

99ebbbd

…template from byteswap class, change contextes

Port 38. EXRSplit example, update CImageLoaderOpenEXR.cpp and patch i…

ee7d540

…t for supporting virtual files input (NEEEDS TESTING!)

Resolve conflicts, merge property_pool branch. @Erfan-Ahmadi you need…

d9605b8

… to begin with 0 index resource

AnastaZIuk merged commit 958f2fd into property_pool Aug 24, 2021

AnastaZIuk deleted the examplesPort branch August 24, 2021 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Porting to new API 3 #172

Porting to new API 3 #172

AnastaZIuk commented Aug 5, 2021

AnastaZIuk commented Aug 5, 2021 •

edited

Loading

AnastaZIuk commented Aug 5, 2021

sadiuk commented Aug 6, 2021

AnastaZIuk commented Aug 6, 2021

AnastaZIuk commented Aug 7, 2021

AnastaZIuk commented Aug 7, 2021

AnastaZIuk commented Aug 7, 2021

sadiuk commented Aug 9, 2021

devshgraphicsprogramming commented Aug 9, 2021

AnastaZIuk commented Aug 9, 2021

AnastaZIuk commented Aug 11, 2021

AnastaZIuk commented Aug 11, 2021

AnastaZIuk commented Aug 11, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 15, 2021

devshgraphicsprogramming commented Aug 16, 2021

AnastaZIuk commented Aug 16, 2021

devshgraphicsprogramming Aug 16, 2021

AnastaZIuk Aug 16, 2021

AnastaZIuk Aug 16, 2021

devshgraphicsprogramming Aug 16, 2021

devshgraphicsprogramming Aug 16, 2021

AnastaZIuk Aug 16, 2021

devshgraphicsprogramming Aug 17, 2021 •

edited

Loading

devshgraphicsprogramming Aug 17, 2021

Crisspl Aug 18, 2021

AnastaZIuk Aug 18, 2021

AnastaZIuk Aug 18, 2021

Porting to new API 3 #172

Porting to new API 3 #172

Conversation

AnastaZIuk commented Aug 5, 2021

AnastaZIuk commented Aug 5, 2021 • edited Loading

AnastaZIuk commented Aug 5, 2021

sadiuk commented Aug 6, 2021

AnastaZIuk commented Aug 6, 2021

AnastaZIuk commented Aug 7, 2021

AnastaZIuk commented Aug 7, 2021

AnastaZIuk commented Aug 7, 2021

sadiuk commented Aug 9, 2021

devshgraphicsprogramming commented Aug 9, 2021

AnastaZIuk commented Aug 9, 2021

AnastaZIuk commented Aug 11, 2021

AnastaZIuk commented Aug 11, 2021

AnastaZIuk commented Aug 11, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 14, 2021

AnastaZIuk commented Aug 15, 2021

devshgraphicsprogramming commented Aug 16, 2021

AnastaZIuk commented Aug 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devshgraphicsprogramming Aug 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnastaZIuk commented Aug 5, 2021 •

edited

Loading

devshgraphicsprogramming Aug 17, 2021 •

edited

Loading