-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAD emulated float64 #114
Open
Przemog1
wants to merge
84
commits into
master
Choose a base branch
from
emulated_float64_t
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CAD emulated float64 #114
Changes from 66 commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
eaff54a
Added tests for emulated_float64_t
Przemog1 1abd122
Implemented emulated float64 type
Przemog1 0307779
Merge branch 'master' of github.com:Devsh-Graphics-Programming/Nabla-…
Przemog1 2e00f20
Added emulated float64 test
Przemog1 2ad6a6c
Fixed GPU values test
Przemog1 ea4fbbf
Saving work
Przemog1 2a878a0
Created emulated_float64_t tests
Przemog1 1169a13
Implemented add sub i mul operators
Przemog1 2d5d301
Adjusted tests
Przemog1 f17208a
Saving work
Przemog1 85babd0
Added more tests
Przemog1 5aaabfd
Merge branch 'master' of github.com:Devsh-Graphics-Programming/Nabla-…
Przemog1 25dfb67
Saving work
Przemog1 c53f5c8
Updated tests
Przemog1 822446f
Refactorization
Przemog1 deaa9f2
Fixes
Przemog1 f99b039
Revived GPU tests
Przemog1 54cf5e9
Saving work
Przemog1 10605e9
Resolved conflicts, merged master
Przemog1 aefcde9
Saving work
Przemog1 9b1edf6
Saving work
Przemog1 8e853f5
No Float64 cap
Przemog1 0bfc208
Refactor
Przemog1 293ec73
Saving work
Przemog1 b6b11ae
Saving work
Przemog1 dc10103
Implemented casting functions for emulated_float64_t
Przemog1 912f012
Updated tests
Przemog1 da25126
Fixes
Przemog1 70ee941
Fixed shaders so they compile even if portable_float64_t is not emulated
Przemog1 c08cd35
Saving work
Przemog1 a6b14da
Updated examples
Przemog1 f8f2c23
Fixed a bug
Przemog1 a9e1007
Reduced branches in operator+
Przemog1 1750aef
Enhanced more tests, more fixes
Przemog1 5e47cf3
Added example 64
Przemog1 48b4a40
Removed emulated float tests from example 22
Przemog1 904da40
64 bit float type is now determined by device capabilities
Przemog1 d6f0c58
Refactor
Przemog1 7f7b485
More refactor
Przemog1 cdafbbc
Fixes
Przemog1 aebab4a
More fixes
Przemog1 62f8a54
Even more fixes
Przemog1 8c873fa
Added more tests
Przemog1 af5ae27
Minor tests improvement
Przemog1 846e7aa
Resolved conflicts, merged master
Przemog1 a4fe41d
Added ef64_benchmark
Przemog1 ca02166
Tests works
Przemog1 843ee6a
Saving work
Przemog1 7422248
Saving work
Przemog1 6915664
Benchmark works
Przemog1 582f002
Saving work
Przemog1 8c37152
Improved benchmark
Przemog1 3912137
Added more benchmarks
Przemog1 031b1bc
Saving old version
Przemog1 239b3b0
Refactored example 64
Przemog1 0b39d2d
Saving work
Przemog1 879860a
Resolved conflicts, merged emulated_float64_t
Przemog1 3c063f8
Fixed benchmarks
Przemog1 ac97c37
Corrections
Przemog1 38282a3
Fix
Przemog1 b5cb225
Merge pull request #150 from Devsh-Graphics-Programming/ef64_benchmark
Przemog1 fa5a77b
Updated example 64
Przemog1 6dbde45
Fixed benchmark
Przemog1 5bd5c02
Fixed _static_cast
Przemog1 e4a42f4
Updated example
Przemog1 a80dcf8
Merge branch 'master' of https://github.com/Devsh-Graphics-Programmin…
Przemog1 44aec1e
Merge branch 'master' into emulated_float64_t
Erfan-Ahmadi aff6223
Fixes after Resolving Shader Conflicts
Erfan-Ahmadi b4ad0b6
Resolved conflicts, merged master
Przemog1 ad0e24f
Implemented nbl::hlsl::mul
Przemog1 d62f779
Fixed array_get and array_set
Przemog1 ce7e866
Saving work
Przemog1 cee85d1
Refactor
Przemog1 a8a7802
Saving work
Przemog1 68d9ea0
Improvements
Przemog1 84906bb
Refactor
Przemog1 a7d1600
Fixes
Przemog1 6fec756
Merge branch 'cpp_compat_intrinsics_refactor' of github.com:Devsh-Gra…
Przemog1 4c58e03
Saving work
Przemog1 73ac5c8
Merge branch 'master' of github.com:Devsh-Graphics-Programming/Nabla-…
Przemog1 01b05ce
Merge branch 'cpp_compat_intrinsics_refactor' of github.com:Devsh-Gra…
Przemog1 1d133bb
Saving work
Przemog1 9649fda
Fixes
Przemog1 383fb3c
Merge branch 'ef64_t' into emulated_float64_t
Przemog1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
03_DeviceSelectionAndSharedSources/app_resources/float64_t_test.hlsl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#pragma wave shader_stage(compute) | ||
#include "common.hlsl" | ||
#include <nbl/builtin/hlsl/emulated_float64_t.hlsl> | ||
|
||
[numthreads(256,1,1)] | ||
void main() | ||
{ | ||
const emulated::float64_t a = _static_cast<emulated::float64_t>(6.9f); | ||
const emulated::float64_t b = _static_cast<emulated::float64_t>(4.5f); | ||
|
||
vk::RawBufferStore<emulated::float64_t::storage_t>(0,(a*b).data); | ||
|
||
const float asdf = 1.0f; | ||
const float asdff = 1.0f; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,7 +68,7 @@ constexpr std::array<float, (uint32_t)ExampleMode::CASE_COUNT> cameraExtents = | |
600.0, // CASE_8 | ||
}; | ||
|
||
constexpr ExampleMode mode = ExampleMode::CASE_7; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. revert these changes please, I changed shader compilation a lot, it will introduce conflicts |
||
constexpr ExampleMode mode = ExampleMode::CASE_8; | ||
|
||
class Camera2D | ||
{ | ||
|
@@ -993,6 +993,10 @@ class ComputerAidedDesign final : public examples::SimpleWindowedApplication, pu | |
shaders[1] = loadCompileAndCreateShader(fragmentShaderPath, IShader::E_SHADER_STAGE::ESS_FRAGMENT); | ||
shaders[2] = loadCompileAndCreateShader(debugfragmentShaderPath, IShader::E_SHADER_STAGE::ESS_FRAGMENT); | ||
shaders[3] = loadCompileAndCreateShader(resolveAlphasShaderPath, IShader::E_SHADER_STAGE::ESS_FRAGMENT); | ||
assert(shaders[0]); | ||
assert(shaders[1]); | ||
assert(shaders[2]); | ||
assert(shaders[3]); | ||
#endif | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
umm this is unsafe, you're writing to gpu virtual address of 0u, you might crash. you create a buffer and pass the address via push constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it kinda looks like a file someone forgot to remove (no chanes in 03 main.cpp)