Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support license caching #634

Merged
merged 9 commits into from
Jan 18, 2025
Merged

feat: support license caching #634

merged 9 commits into from
Jan 18, 2025

Conversation

probakowski
Copy link
Collaborator

This PR adds support for license caching by storing the license obtained from SERVER_UPGRADE_LICENSE message and sending CLIENT_LICENSE_INFO if we have license requested by the server stored.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Coverage Report 🤖 ⚙️

Past:
Total lines: 27418
Covered lines: 17075 (62.28%)

New:
Total lines: 27644
Covered lines: 17065 (61.73%)

Diff: -0.55%

[this comment will be updated automatically]

@awakecoding
Copy link
Contributor

👀 thanks for improving licensing support, one of the trickiest areas of RDP

CBenoit
CBenoit reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for working on this!!

crates/ironrdp-client/src/config.rs Outdated Show resolved Hide resolved
crates/ironrdp-connector/src/connection.rs Outdated Show resolved Hide resolved
crates/ironrdp-connector/src/lib.rs Outdated Show resolved Hide resolved
crates/ironrdp-client/src/config.rs Outdated Show resolved Hide resolved
CBenoit
CBenoit reviewed Jan 16, 2025
View reviewed changes
crates/ironrdp-connector/src/license_exchange.rs Outdated Show resolved Hide resolved
crates/ironrdp-connector/src/lib.rs Outdated Show resolved Hide resolved
CBenoit
CBenoit approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just added a little bit of documentation in the public API. (Although I didn’t write anything extensive, anything interesting you could add will be greatly appreciated.)
Thank you again for moving this forward!

@CBenoit CBenoit enabled auto-merge (squash) January 18, 2025 14:33
@CBenoit CBenoit merged commit dd221bf into master Jan 18, 2025
9 checks passed
@CBenoit CBenoit deleted the probakowski/license-cache branch January 18, 2025 14:34
@devolutionsbot devolutionsbot mentioned this pull request Jan 17, 2025
Open
@probakowski probakowski mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@probakowski @awakecoding @CBenoit