INF-928 Add WaitForInstance after modifying the instance on restoration #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer go tooling use go mod instead of go package for dependency management. This commit replaces the files between both tools. Refs [INF-928](https://mydevex.atlassian.net/browse/INF-928)
After restoring an instance, AWS keeps the default security groups. So, odin needs to modify the instance to adjust it, but it also needs to wait for the modification to be in place, or the instance might not get connections right. Refs [INF-928](https://mydevex.atlassian.net/browse/INF-928)
ifosch
changed the title
eporter82
approved these changes
Aug 20, 2024
dsager
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After restoring an instance, AWS keeps the default security
groups. So, odin needs to modify the instance to
adjust it, but it also needs to wait for the modification to be in
place, or the instance might not get connections right.
Add WaitForInstance after modifying the instance on restoration
Refs INF-928