Add WaitForInstance after modifying the instance on restoration #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move cloning instance to separate command
Updating from Devex
Update odin README
Updating from Devex
Readability improvements (I)
This command uses the sitemap package to expose via Push Gateway a series of metrics over a list of publicly accessible sitemap files.
This adds the `cloudinary` package from [cloudinary_exporter](https://github.com/ifosch/cloudinary_exporter). The cloudinary_exporter is the one currently used to get usage metrics from cloudinary, but it is faulty due to how the Cloudinary's Admin API behaves. To fix that, this exporter is going to be replaced with a collector, written as a dextre subcommand, which will send metrics to Push Gateway. Refs [DVX-7220](https://mydevex.atlassian.net/browse/DVX-7220)
This subcommand requests the Cloudinary's Admin API, using credentials provided through environment variables, and pushes the metrics collected to the Push Gateway specified by `--push-gateway` CLI argument. Refs [DVX-7220](https://mydevex.atlassian.net/browse/DVX-7220)
Use newer versions of go and reuse our dep setup instead of the previous manual one.
Test how codecov works and if it provides something useful for us.
This adds a new command with a subcommand to dextre to create a golden copy from a URL. Usage: ``` dextre robots generate-golden -g <destination file> <origin url> ``` This golden copy will be used by another `robots` subcommand to check the URL has not changed. Refs [DVX-7420](https://mydevex.atlassian.net/browse/DVX-7420)
Packages in pkg are supposed to be reused out of spaceflight, while those in internal, are supposed to be reused within spaceflight. Refs [DVX-7420](https://mydevex.atlassian.net/browse/DVX-7420)
This adds a function to get Base64 digest of a io.Reader so it can be quickly compared to other ones. This function is using SHA1 for the digest. Refs [DVX-7420](https://mydevex.atlassian.net/browse/DVX-7420)
This subcommand will check the specified URL content is matching the specified golden file and pushes the result (0 if matching, 1 otherwise), to Push Gateway. This change also adds some useful functions to check required arguments are present, and to get the content from the URL. Refs [DVX-7420](https://mydevex.atlassian.net/browse/DVX-7420)
This change extends usage of check functions with must to robots_generate_golden.go Refs [DVX-7421](https://mydevex.atlassian.net/browse/DVX-7421)
This makes other dextre subcommands to make use of checkPGAddress and must. Refs [DVX-7421](https://mydevex.atlassian.net/browse/DVX-7421)
This is intended as a change to merge to test auto-merge.
Newer go tooling use go mod instead of go package for dependency management. This commit replaces the files between both tools. Refs [INF-928](https://mydevex.atlassian.net/browse/INF-928)
After restoring an instance, AWS keeps the default security groups. So, odin needs to modify the instance to adjust it, but it also needs to wait for the modification to be in place, or the instance might not get connections right. Refs [INF-928](https://mydevex.atlassian.net/browse/INF-928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After restoring an instance, AWS keeps the default security
groups. So, odin needs to modify the instance to
adjust it, but it also needs to wait for the modification to be in
place, or the instance might not get connections right.
This PR also updates the dependency tool from Gopkg to go mod.
Refs INF-928