Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/all blocks #15

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Feat/all blocks #15

wants to merge 26 commits into from

Conversation

aashaykapoor
Copy link

No description provided.

Copy link

@raghukapur9 raghukapur9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the comments

};

const handlePagination = (page: any) => {
console.log('Page updated to ', page.selected);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this console statement

@@ -0,0 +1,48 @@

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have a different CSS, these guys don't have a different CSS file for other components

@@ -1544,6 +1544,87 @@ export type GQLBlockQuery = {
} | null;
};

export type GQLBlockItemFragment = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be pushed

const blockData = result.blocks;
setData(blockData);
} catch (err) {
console.error('Error fetching block data:', err);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this statement

@@ -0,0 +1,22 @@
'use client';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the need for this file?

cell: (row: any) => (
<button
type="button"
onClick={() => console.log('Button clicked for:', row.name)}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this console statement required?

{/* <img
alt="token-image"
className="h-6 w-6 rounded-mg"
src="https://s3-alpha-sig.figma.com/img/e277/e70a/7d31d7c806a31e7b6d3b103fcc13c7b0?Expires=1724630400&Key-Pair-Id=APKAQ4GOSFWCVNEHN3O4&Signature=W8NXFXFRXFo95uObTjxmaUI9BJf8uyaLK-QKg4ZI8sFQopN4p8vJSAviLMYMGNTi4Qzk7FJw~MPTefqGBZoeKa7OyG6yc1DZzS9qFyTHKvX82Wm2cP7eEyzd6l4Ru~qKfMAelUrO8ssCoN7BJUG~VxdojaAYoUTaNQts2WxFGtkv-VNYRQReA9es8OQInZit-GDT9WonuJAVk5TZj2LyOvBCgjwVuVJuf0qov9zDlCp26fmFOYZGPFgh~67-CIGNAlbM1762y9BSfTJ2SLxNDnj~9Ii7jUf48FChcHk7AhGBSLKpJyPW1mkYrmvY1pY48mcR7AXaCElsydXkUpthqQ__"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have hardcoded value here

@@ -1,14 +1,47 @@
const fs = require('fs');
const path = require('path');

module.exports.continueTx = fs.readFileSync(path.join(__dirname, 'continueTx.graphql'), 'utf8');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are changes in this file?

@@ -1,29 +1,107 @@
const fs = require('fs');
const path = require('path');

module.exports.balance = fs.readFileSync(path.join(__dirname, 'balance.graphql'), 'utf8');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are changes in this file? revert it to the original state

@@ -1,5 +1,11 @@
const fs = require('fs');
const path = require('path');

module.exports.statusChange = fs.readFileSync(path.join(__dirname, 'statusChange.graphql'), 'utf8');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are changes in this file? revert it to the original state

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this deleted

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are changes in this file? revert it to the original state

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check. this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants