Skip to content

Commit

Permalink
testing: hammerhead testing build (#8261)
Browse files Browse the repository at this point in the history
<!--
Thank you for your contribution.

Before making a PR, please read our contributing guidelines at

https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution

We recommend creating a *draft* PR, so that you can mark it as 'ready
for review' when you are done.
-->

## Purpose
Hammerhead returned invalid results.

## Approach
Update testcafe-hammerhead package.

## References
Hammerhead PR:
DevExpress/testcafe-hammerhead#3016
Closes: #8237

## Pre-Merge TODO
- [ ] Write tests for your proposed changes
- [ ] Make sure that existing tests do not fail

---------

Co-authored-by: Bayheck <[email protected]>
  • Loading branch information
Bayheck and Bayheck authored Sep 16, 2024
1 parent ef32f4c commit 7fb159d
Show file tree
Hide file tree
Showing 5 changed files with 38 additions and 11 deletions.
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"@babel/runtime": "^7.23.2",
"@devexpress/bin-v8-flags-filter": "^1.3.0",
"@devexpress/callsite-record": "^4.1.6",
"@types/node": "^20.14.5",
"@types/node": "20.14.5",
"address": "^2.0.2",
"async-exit-hook": "^1.1.2",
"babel-plugin-module-resolver": "5.0.0",
Expand Down Expand Up @@ -142,7 +142,7 @@
"source-map-support": "^0.5.16",
"strip-bom": "^2.0.0",
"testcafe-browser-tools": "2.0.26",
"testcafe-hammerhead": "31.7.2",
"testcafe-hammerhead": "31.7.3",
"testcafe-legacy-api": "5.1.8",
"testcafe-reporter-json": "^2.1.0",
"testcafe-reporter-list": "^2.2.0",
Expand All @@ -165,6 +165,7 @@
"@rollup/plugin-commonjs": "^11.0.2",
"@rollup/plugin-inject": "^4.0.2",
"@rollup/plugin-node-resolve": "^7.1.1",
"@testcafe/publish-please": "^5.6.0",
"@types/callsite": "^1.0.30",
"@types/chai": "^3.5.2",
"@types/debug": "^4.1.5",
Expand Down Expand Up @@ -221,7 +222,6 @@
"multer": "1.4.4-lts.1",
"openssl-self-signed-certificate": "^1.1.6",
"proxyquire": "^2.1.0",
"@testcafe/publish-please": "^5.6.0",
"react": "^16.13.1",
"recursive-copy": "^2.0.5",
"rollup": "2.16.1",
Expand Down
12 changes: 12 additions & 0 deletions test/functional/fixtures/regression/gh-8261/pages/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>gh-8261</title>
</head>
<body>
<a href="example">
<div style="width: 100px; height: 100px"></div>
</a>
</body>
</html>
5 changes: 5 additions & 0 deletions test/functional/fixtures/regression/gh-8261/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
describe('[Regression](GH-8261)', function () {
it('Element with first DOMRect from getClientRects with zero height/width should be visible', function () {
return runTests('testcafe-fixtures/index.js', 'Element should be visible', { only: 'chrome' });
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { Selector } from 'testcafe';

fixture('GH-8261- Element with first DOMRect from getClientRects with zero height/width should be visible')
.page`http://localhost:3000/fixtures/regression/gh-8261/pages/index.html`;

test('Element should be visible', async t => {
const element = Selector('a');

await t.expect(element.visible).ok();
});

0 comments on commit 7fb159d

Please sign in to comment.