-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reexports. #529
Open
Igggr
wants to merge
8
commits into
master
Choose a base branch
from
igggr/reexports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add reexports. #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgruba
suggested changes
Oct 12, 2021
packages/devextreme-vue-generator/src/component-generator.test.ts
Outdated
Show resolved
Hide resolved
packages/devextreme-vue-generator/src/component-generator.test.ts
Outdated
Show resolved
Hide resolved
`export {\n <#= it.reexports.filter(n => n != 'default').join(',\\n ') #>,\n} from "<#= it.widgetsPackage #>/<#= it.widgetImport.path #>";\n` + | ||
`<#?#>` + | ||
|
||
`<#? !it.defaultExport && it.reexports?.includes('default') #>` + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no test for this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided not to add test - but delete this line. Widget themself will always be default export.
…ther default will never appear
This reverts commit ce221fe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reexports
packages/devextreme-vue/vue2-strategy/src/vector-map.ts