Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Enabling cube rotation via 'right-click-drag' # 277 #282

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

Aaryan-Ajith-Dev
Copy link
Contributor

Description

I have added a listener for the right mouse down.
This now detects mouse downs by the right click and handles them as desired.
The functionality for the left is left untouched.

Fixes: #277

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • [x ] I have made this from my own
  • I have taken help from some online resourses
  • My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK (if applicable)

Copy link

github-actions bot commented Jun 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Dev-tanay
Copy link
Owner

Hi @Aaryan-Ajith-Dev
Thank you for your effort. However, your current code does not fulfill the requirement of enabling cube rotation via 'right-click-drag'. Specifically, it only allows the cube rotation to be initiated with the left mouse button. Could you please revise it to enable rotation with the right mouse button as well?

@Aaryan-Ajith-Dev
Copy link
Contributor Author

Rubik.Cube.-.Google.Chrome.2024-06-07.22-34-52.mp4

I apologize for the oversight @Dev-tanay.
I have attached a small video file for how it was working for me (in my branch), and I had committed the same.
Thank you for your time

@Dev-tanay Dev-tanay merged commit d441fec into Dev-tanay:main Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Enabling cube rotation via 'right-click-drag'
2 participants