Remove empty output from missing-source-info #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was this taking 30s for you? For me it takes 7 seconds after I optimized it in #505 already and this PR doesn't really affect the runtime on my end... |
|
You're right - I don't work in this repo often, and I had forgotten that you need to manually build code before running the tasks. So I was running an old version from before your changes. Switching to doing the uniquing after each group rather than after each add still helps. |
robojumper
approved these changes
Oct 28, 2023
delphiactual
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also as a bonus, rearranged some statements to make this run in 3.5s down from 30s.