Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save manifest tables separately in IDB #10819

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Nov 28, 2024

This appears to alleviate Firefox's consternation regarding the manifest as a single object being too large. It can both save the manifest, and load it. Chromium-based browsers and Safari don't care either way.

Fixes #10816

Copy link
Contributor

@chainrez chainrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems sane. After running this a few days no issues.

@chainrez chainrez merged commit bb36145 into master Dec 4, 2024
7 checks passed
@chainrez chainrez deleted the separate-idb-tables branch December 4, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to OPFS or separate IDB entries per table for manifest storage, at least for Firefox
2 participants