Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example notebooks for launch #580

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

MatthiasHauthDeltares
Copy link
Contributor

@MatthiasHauthDeltares MatthiasHauthDeltares commented Oct 2, 2024

Issue addressed

Solves #540

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

Explain how you addressed the resolution of the related issue, what choices you made and why.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

Copy link
Contributor

@sahand-asgarpour sahand-asgarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthiasHauthDeltares Finally the PR tests are passed! Hoooraaay!

Can you please go through the notebooks created and make sure that the notebooks do not have:

  • useless imports
  • double imports
  • background map with colour that makes the legend unreadable

I have done so for the newly created damages notebooks.

Thanks

@sahand-asgarpour sahand-asgarpour added documentation Improvements or additions to documentation Launch labels Nov 20, 2024
@sahand-asgarpour sahand-asgarpour added this to the Launch 2024 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Launch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants