Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit imod python version to <0.18.0, before refactor is merged #353

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Nov 8, 2024

The 0.18.0 release of iMOD Python will feature a significant refactoring of the MetaSWAP objects in iMOD Python.
Once 0.18.0 is released, the fixes here #352 will update primod and the test fixtures to be functional again.

The 0.18.0 release will break the current main, so to ensure it does not when iMOD Python 0.18.0 is released. I limit it in the pixi.toml here to keep the CI stable. This gives me the time to get #352 to work.

@JoerivanEngelen
Copy link
Contributor Author

JoerivanEngelen commented Nov 11, 2024

I discussed with @HendrikKok, the release test job is failing, but this is due to changes outside this PR. In the release test job, and old version of Ribasim is used, which isn't able to compute water balances without errors larger than 1e-4. So we can merge this.

@JoerivanEngelen JoerivanEngelen merged commit 640055d into main Nov 11, 2024
9 of 10 checks passed
@JoerivanEngelen JoerivanEngelen deleted the limit_imod_python_version branch November 11, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants