Imod6 1082 modflow6 packages optional #201
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Most of the changes seem ok. The weird thing is that all functions from line 479 of dfm_metamod.py seem to be changed (at least they are red) but they are not as far as I can see. Can you changes this maybe? For now its hard for me to review that part of the changes at this point. Perhaps a rebase first?
| @@ -155,7 +172,8 @@ def set_mapping(self) -> None: | |||
|
|
|||
| def update(self) -> None: | |||
| # heads from modflow to MetaSWAP | |||
| self.exchange_mod2msw() | |||
| if self.map_mod_msw["mod2msw_head"] is not None: | |||
| self.exchange_mod2msw() | |||
There was a problem hiding this comment.
Should this be optional? This affects the core coupling between MF6 and MEtaSWAP?
| "mf6_riv_active": self.mf6.get_river_drain_flux_estimate( | ||
| ).size | ||
| try: | ||
| array_dims["mf6_riv_active"] = self.mf6.get_river_drain_flux_estimate( |
There was a problem hiding this comment.
Is it not better to check if the specific package is defined in TOML-file? There is no need to test the function itself right? The function only doesn't work if the package names are None?
| "msw-ponding2dflow2d_flux", | ||
| self.dfm.get_current_time_days(), | ||
| ) | ||
| self.matrix_product( |
There was a problem hiding this comment.
I guess the check is now only done in matrix_product() ?
|
|
||
| # for calculating the realised ponding volume, the flux need to be split up in positive and negative values |
There was a problem hiding this comment.
what changed here? All changes below don't seem to be changes right? Just a shift down? Can you change this maybe? Its hard for me to review all changes below...
| super().__init__(lib_path, lib_dependency, working_directory, timing) | ||
|
|
||
| def get_value_ptr(self, name: str) -> NDArray: |
There was a problem hiding this comment.
why is this in the wrapper? This is standard xmi right?
Please review: