Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read spatial joints #416

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Read spatial joints #416

merged 3 commits into from
Nov 20, 2024

Conversation

Santonia27
Copy link
Collaborator

spatial joints were not read into the model when fm.read()

added spatial joints to read_geoms

panosatha
panosatha approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@panosatha panosatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this is fine, but something to generally keep in mind is that now we assume that all the geometry files are in geojson format.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Santonia27 Santonia27 merged commit 2a7d2a8 into main Nov 20, 2024
6 checks passed
@Santonia27 Santonia27 deleted the read_spatial_joints branch November 20, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panosatha panosatha panosatha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Santonia27 @panosatha