Update to newest Delft version and setup impacted population #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Santonia27
commented
Oct 30, 2024
•
Santonia27
commented
- update all headers to align with the newest Delft Fiat version
- add function to setup_impacted_population
- add clipping of exposure data to hazard if used setup_hazard. In the future will be added to delft fiat to have some tolerance.
* make variable names compatible with new Delft Fiat version * add gfh attribute to setup exposure buildings * update primary and secondary classification * add docstring, add ground elevation unit, fix naming structure content * setup populatoin remove geometry * remove capitalized * update gis * uncomment zonal means
…orund elevation unit
…ple step function
…setup_impacted_population
…setup_impacted_population
|
Could you resolve the merge conflict? I'll review after. thanks |
…setup_impacted_population
…setup_impacted_population
…setup_impacted_population
…setup_impacted_population
tests/test_roads.py
Outdated
Comment on lines
89
to
90
| "fn_damages_structure", | ||
| "max_damages_structure", |
There was a problem hiding this comment.
@dalmijn @Santonia27 I get the error below in Delft-FIAT 0.20 and think this can be solved by changing damages in these lines with damage.
2024-11-27 15:41:40 ERROR For type: 'damage' no matching columns were found for fn_damage_* and max_damage_* columns.
Suggested change
| "fn_damages_structure", | |
| "max_damages_structure", | |
| "fn_damage_structure", | |
| "max_damage_structure", |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.