Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: external forcings converter #647

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

feat: external forcings converter #647

wants to merge 16 commits into from

Commits on Jun 6, 2024

  1. Initial setup of ext_old_to_new tool 

    * basic program structure
* processing of a single [Meteo] block as first example code
* testcase c081 with multiple combined wind files.
    @arthurvd
    arthurvd committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    559ddac View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. converter can now convert e02_dflowfm\f006_external_forcing\c011_extr… 

    …apolate_slr\
    @FlorisBuwaldaDeltares
    FlorisBuwaldaDeltares committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1bb5532 View commit details
    Browse the repository at this point in the history

  2. modified tests to no longer use local directories

    @FlorisBuwaldaDeltares
    FlorisBuwaldaDeltares committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    2ab564f View commit details
    Browse the repository at this point in the history

  3. added extrapolate_slr case

    @FlorisBuwaldaDeltares
    FlorisBuwaldaDeltares committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1fb7583 View commit details
    Browse the repository at this point in the history

  4. Added some exception handling, now validate Meteo quantity before mak… 

    …ing a meteo block.
    @FlorisBuwaldaDeltares
    FlorisBuwaldaDeltares committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    851975d View commit details
    Browse the repository at this point in the history

  5. added basinsquares test, fixed rainschematic.ext as an uncommented li… 

    …ne caused the converter to crash
    @FlorisBuwaldaDeltares
    FlorisBuwaldaDeltares committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f8dfbce View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. restore rainschematic.ext as otherwise unit tests get broken

    @FlorisBuwaldaDeltares
    FlorisBuwaldaDeltares committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    34704fa View commit details
    Browse the repository at this point in the history

  2. autoformat: isort & black

    @FlorisBuwaldaDeltares
    FlorisBuwaldaDeltares committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c1033df View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. chore!: Refactored ext old converter to prepare for more other quanti… 

    …ties than only Meteo

See ConverterFactory and BaseConverter subclasses

ext_old_to_new is now a subdirectory, instead of a single script, to keep things organized.

BREAKING CHANGE: in hydrolib.core: renamed ExtOldFileType.Poyfile to ExtOldFileType.InsidePolygon
    @arthurvd
    arthurvd committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fdb2981 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge branch 'main' into feature/621_extforce_converter

    @arthurvd
    arthurvd committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    096d194 View commit details
    Browse the repository at this point in the history

  2. Remove non-existing structure file reference in a test MDU

    @arthurvd
    arthurvd committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    9266e7b View commit details
    Browse the repository at this point in the history

  3. Remove obsolete keywords from example windcase.mdu

    @arthurvd
    arthurvd committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    314fbc8 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. New feature exclude_unset in ModelSaveSettings 

    Makes serialized model files lean by only serializing the field values that have been explicitly set.
Only implemented for IniModel (and IniBasedModel).
    @arthurvd
    arthurvd committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9dd1d70 View commit details
    Browse the repository at this point in the history

  2. Combine power of LegacyFMModel and ResearchFMModel 

    On the longer term, can we get rid of `LegacyFMModel` (which only exists to support `[Model]` in MDU files), and have this backwards compatibility implemented in a less ad-hoc way?
    @arthurvd
    arthurvd committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e2720ad View commit details
    Browse the repository at this point in the history

  3. Work-in-progress making converter tool more flexible for repeated runs 

    Misc cleanup + new cmdline args:
* --postfix / -p : Append POSTFIX to the output filenames (before the extension).
* --[no]backup : Create a backup of each file that will be overwritten.
    @arthurvd
    arthurvd committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    26e6d9b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/621_extforce_converter

    @arthurvd
    arthurvd committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2fb8c8b View commit details
    Browse the repository at this point in the history