new pens for various departments #2735

mishka420 · 2025-01-15T07:39:34Z

check out these cool and marketable pens! collect them all! sprites by kushbreth

About the PR

New pens have been added for:
Captain, HoP, HoS, Mystagogue, Logistics Officer, Chief Medical Officer, Chief Justice, Warden, and Psychologist.

Why / Balance

adds variety to standardized pens. fun little "rare" item. maybe someday they can be thief objectives but today is not that day.

Technical details

yaml changes.

Media

Requirements

[X ] I have tested all added content and changes.
[X ] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

add: Added fancy new pens for (most) command roles, warden and psychologist. Look for them in your PDA!
tweak: Changed graphics for Captain and Head of Personnel's pens.

github-actions · 2025-01-15T07:40:09Z

RSI Diff Bot; head commit 0862fd9 merging into f3d2632
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Objects/Misc/pens.rsi

State	Old	New	Status
pen_cap2			Added
pen_ce			Added
pen_cj			Added
pen_cmo			Added
pen_hop2			Added
pen_hos			Added
pen_lo			Added
pen_mystagogue			Added
pen_psych2			Added
pen_warden			Added

Edit: diff updated after 0862fd9

Radezolid

Key points:

Minor issues with the comments.
Create a new pen.yml in it's respective folder in the _DV namespace creating the pens you made there.
Create a new pens.rsi in it's respective folder in the _DV namespace, creating a new meta.json and adding the files you created there.
Minor convention issues on the pens.

Radezolid · 2025-01-15T16:07:43Z

Resources/Prototypes/Entities/Objects/Devices/pda.yml

Small issue here, it should be DeltaV and the formatting of the comment is slightly wrong. An example is:

# Begin DeltaV changes blah blah # End DeltaV changes

Radezolid · 2025-01-15T16:08:30Z

Resources/Prototypes/Entities/Objects/Devices/pda.yml

@@ -678,7 +702,7 @@
  - type: Icon
    state: pda-chemistry

- type: entity
+- type: entity 


Remove the added space

Radezolid · 2025-01-15T16:25:38Z

Resources/Prototypes/Entities/Objects/Misc/pen.yml

-  - type: Tending # Shitmed
-    speed: 0.55
-  - type: SurgeryTool # Shitmed
-    startSound:
-      path: /Audio/_Shitmed/Medical/Surgery/retractor1.ogg
-    endSound:
-      path: /Audio/_Shitmed/Medical/Surgery/hemostat1.ogg


Restore this or explain why do you plan on removing this.
If you are trying to remove it you need to comment it out instead of deleting it,

Radezolid · 2025-01-15T16:30:57Z

Resources/Prototypes/Entities/Objects/Misc/pen.yml

Move the new pens to it's own file in the _DV namespace. Also don't modify the HoP's pen, if you need to change it you can make a new one and then swap it in the PDA.

Radezolid · 2025-01-15T16:32:07Z

Resources/Textures/Objects/Misc/pens.rsi/meta.json

Restore it to it's previous state and make a new pens.rsi in the _DVnamespace.

Radezolid · 2025-01-15T16:35:24Z

Resources/Prototypes/_DV/Entities/Objects/Devices/pda.yml

+    #new cj pen
+    penSlot:
+      startingItem: PenCJ
+      priority: -1
+      whitelist:
+        tags:
+        - Write
+    #end cj pen


Remove these comments, they aren't needed

Radezolid · 2025-01-15T16:35:34Z

Resources/Prototypes/_DV/Entities/Objects/Devices/pda.yml

@@ -66,7 +66,7 @@
  id: ChiefJusticePDA
  name: chief justice PDA
  description: Whosoever bears this PDA is the law.
-  components:
+  components: 


Remove that space.

Radezolid · 2025-01-15T16:43:42Z

Resources/Prototypes/Entities/Objects/Misc/pen.yml

+- type: entity
+  name: chief medical officer's pen
+  parent: PenEmbeddable
+  id: PenCMO


Follow the YAML convention of type > abstract > parent > id > name > description > components meaning you should swap the order making the name come after the id in this case leaving it like this:

- type: entity parent: PenEmbeddable id: PenCMO name: chief medical officer's pen

Do this when you transfer these pens to the new file.

mishka420 · 2025-01-15T17:42:02Z

ah- this code was made pre-shitmed and i ported old pen code back in, sorry about that lmao. i'll start working on fixing these. thanks for the review!

Radezolid · 2025-01-15T17:44:02Z

ah- this code was made pre-shitmed and i ported old pen code back in, sorry about that lmao. i'll start working on fixing these. thanks for the review!

No worries, i was just confused why it was nuked

mishka420 · 2025-01-15T19:19:36Z

should be better now. do let me know if i've missed anything. thank you!
~~edit: hold up i forgot to push the changes. sorry gimme a second.~~ we're back!

Radezolid · 2025-01-15T21:01:53Z

Resources/Prototypes/Entities/Objects/Devices/pda.yml

+      whitelist:
+        tags:
+        - Write
+    #end delta v content


Forgor to change to # End DeltaV changes

Radezolid · 2025-01-15T21:02:43Z

Resources/Prototypes/Entities/Objects/Devices/pda.yml

+    # Begin DeltaV changes
+      startingItem: PenCapNew
+    # End DeltaV changes  


Change to a single comment like: startingItem: PenCapNew # DeltaV

Radezolid · 2025-01-15T21:02:53Z

Resources/Prototypes/Entities/Objects/Devices/pda.yml

+    # Begin DeltaV changes
+      startingItem: PenHopNew
+    # End DeltaV changes


Same as above.

Radezolid · 2025-01-15T21:17:14Z

Resources/Prototypes/Entities/Objects/Misc/pen.yml

@@ -125,4 +125,4 @@
  description: A luxurious fountain pen for the hop of the station.
  components:
  - type: Sprite
-    state: pen_hop
+    state: pen_hop


Add a end of file newline

Radezolid · 2025-01-15T21:31:51Z

Resources/Textures/Objects/Misc/pens.rsi/meta.json

@@ -55,5 +55,6 @@
      "name": "pen_centcom-inhand-right",
      "directions": 4
    }
+


Untouch this

Radezolid · 2025-01-15T21:33:36Z

Resources/Prototypes/_DV/Entities/Objects/Misc/pen.yml

+  - type: Sprite
+    sprite: _DV/Objects/Misc/pens.rsi
+    state: pen_lo
+


Remove this line, same as before

Radezolid · 2025-01-15T21:34:26Z

Resources/Prototypes/_DV/Entities/Objects/Misc/pen.yml

+  - type: Sprite
+    sprite: _DV/Objects/Misc/pens.rsi
+    state: pen_cj
+


Remove the spaces from this line.

Radezolid · 2025-01-15T21:34:37Z

Resources/Prototypes/_DV/Entities/Objects/Misc/pen.yml

+  - type: Sprite
+    sprite: _DV/Objects/Misc/pens.rsi
+    state: pen_cap2
+


Same as before, remove the spaces from this line

Radezolid · 2025-01-15T21:34:52Z

Resources/Prototypes/_DV/Entities/Objects/Misc/pen.yml

+  - type: Sprite
+    sprite: _DV/Objects/Misc/pens.rsi
+    state: pen_hop2
+


Remove the spaces from this line.

Radezolid · 2025-01-15T21:35:30Z

Resources/Textures/_DV/Objects/Misc/pens.rsi/meta.json

The JSON should be indented with 4 spaces instead of two.
Also you're missing an End of File newline.

mishka420 · 2025-01-15T22:04:23Z

forgot to untouch the json code. i'll do that when i get home 🤪

mishka420 added 2 commits January 14, 2025 23:06

new pens we are so back

922bc5e

updated to better meet pr guidelines.

c88ec93

mishka420 requested review from a team as code owners January 15, 2025 07:39

github-actions bot added S: Needs Review size/M 64-255 lines Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Jan 15, 2025

Radezolid requested changes Jan 15, 2025

View reviewed changes

addressed review issues.

6f2f0af

Radezolid requested changes Jan 15, 2025

View reviewed changes

fixing my nasty yml

0862fd9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new pens for various departments #2735

new pens for various departments #2735

mishka420 commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

Radezolid left a comment

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

mishka420 commented Jan 15, 2025

Radezolid commented Jan 15, 2025

mishka420 commented Jan 15, 2025 •

edited

Loading

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

Radezolid Jan 15, 2025

mishka420 commented Jan 15, 2025

new pens for various departments #2735

Are you sure you want to change the base?

new pens for various departments #2735

Conversation

mishka420 commented Jan 15, 2025 • edited Loading

About the PR

Why / Balance

Technical details

Media

Requirements

Breaking changes

github-actions bot commented Jan 15, 2025 • edited Loading

Radezolid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mishka420 commented Jan 15, 2025

Radezolid commented Jan 15, 2025

mishka420 commented Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mishka420 commented Jan 15, 2025

mishka420 commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

mishka420 commented Jan 15, 2025 •

edited

Loading