Port Supermatter from Impstation #2717
Open
+3,734
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supermatter .ftl was broken, this fixes it. <!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Easly fix the supermatter .ftl files that was not set correctly, why? i dunno. now its works. --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - fix: Supermatter Annoncements Signed-off-by: FoxxoTrystan <[email protected]>
github-actions
bot
added
size/XL
|
RSI Diff Bot; head commit 26a05e8 merging into f3d2632 Resources/Textures/_EE/Structures/Machines/computers.rsi
Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter.rsi
Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter_sliver.rsi
|
Radezolid
requested changes
Jan 14, 2025
Resources/Prototypes/Entities/Structures/Doors/Shutter/shutters.yml
Outdated
Show resolved
Hide resolved
Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter.rsi/meta.json
Show resolved
Hide resolved
Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter_sliver.rsi/meta.json
Show resolved
Hide resolved
Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter_sliver.rsi/meta.json
Outdated
Show resolved
Hide resolved
|
@Radezolid I think I got everything you had tagged. Let me know if I missed anything 🙂 |
Will review once i get some sleep |
|
i'm really happy you're looking to port this! i do want to let you know that i'm still working on further adjustments on imp. i'll also take the requested changes from this pr into account for our fork, the organisation is admittedly a bit of a mess |
Radezolid
approved these changes
Jan 15, 2025
Lyndomen
approved these changes
Jan 16, 2025
deltanedas
requested changes
Jan 16, 2025
| @@ -65,7 +65,8 @@ private void OnDamage(EntityUid uid, DoAfterComponent component, DamageChangedEv | |||
| { | |||
| // If we're applying state then let the server state handle the do_after prediction. | |||
| // This is to avoid scenarios where a do_after is erroneously cancelled on the final tick. | |||
| if (!args.InterruptsDoAfters || !args.DamageIncreased || args.DamageDelta == null || GameTiming.ApplyingState) | |||
| if (!args.InterruptsDoAfters || !args.DamageIncreased || args.DamageDelta == null || GameTiming.ApplyingState | |||
| || args.DamageDelta.DamageDict.ContainsKey("Radiation")) // imp - Sanity check so people can crowbar doors open to flee from Lord Singuloth | |||
There was a problem hiding this comment.
this isnt needed it was fixed like 2 years ago, radiation doesnt interrupt doafters
| @@ -29,6 +29,7 @@ | |||
| HoSGunStealObjective: 0.5 # DeltaV | |||
| PlutoniumCoreStealObjective: 0.5 # DeltaV, was reverted upstream | |||
| NukeDiskStealObjective: 0.25 | |||
| #StealSupermatterSliverObjective: 0.5 # imp - disabled supermatter steal objectives | |||
There was a problem hiding this comment.
it doesnt exist here so just remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Port the following PRs from Impstation:
Adds the Supermatter crystal as implemented in impstation, a power source that requires active cooling, emitters, and produces radiation. It comes with a monitoring computer, a variety of sound effects, and three delamination types:
Resonance Cascade exists in the code, but will not be chosen as there are no conditions for it in Impstation.
The crystal will announce the expected delamination type once, but the delamination type is checked every update before the delamination occurs, and as a result the delam can change from singularity formation to explosion if the amount of absorbed moles drops below the required number.
The crystal is damaged in a variety of ways:
HeatPenaltyThreshold(Default 40; Value is in C not K).PowerPenaltyThreshold(Default 5000, or 5.0 GeV)MolePenaltyThreshold(Default 1,800 moles)The crystal cannot lose more than 0.2% integrity per update.
The integrity cannot go negative, and delamination will be canceled if the crystal's integrity is restored above 0.
Mapping & Testing Remarks
This PR does not add the supermatter to any stations. I tested this by creating a very basic setup derived from following this guide, but I am by no means an expert.
Why / Balance
Additional content for engineering: Another way to accidentally destroy the station, a way to farm plasma, variety in station power generation.
The steal objective has been commented out in Impstation, I have left it commented out here; however, cutting a sliver of the supermatter is still a function that works and will halve the delamination timer from 30s to 15s.
Technical details
The Beam and Lightning systems now support targeting coordinates as an alternative to targeting entities, and now has support for non-randomized lightning sprites. This is not expected to impact any other uses of the beam or lightning systems.
supermatter.singuloose_moles_modifiersupermatter.do_singuloosesupermatter.tesloose_power_modifiersupermatter.do_tesloosesupermatter.do_force_delamsupermatter.forced_delam_typevariablesupermatter.forced_delam_typesupermatter.do_force_delamis set to true. Note: I was unable to use this cvar from the server console, I suspect because it is an Enum type.supermatter.rads_basesupermatter.rads_modifiersupermatter.yell_timerMedia
Computer board can be printed in circuit imprinter:
Supermatter Crystal, Active:
CE Hardsuit immune:
Urist McHands not immune:
urist-destroyed.mp4
Supermatter stating integrity is falling:
SM integrity healing:
Explosive Delam:
delam-explosive.mp4
Singulo Delam (w/Sliver taken):
delam-singulo.mp4
Tesla Delam (w/Sliver taken):
Requirements
Breaking changes
Content.Shared.Beam.Components.CreateBeamSuccessEvent.Targetis now nullable and will require null handling.Content.Server.Lightning.HitByLightningEvent.Sourceis now nullable and will require null handling.I did not see any usages of these properties in the codebase, but any future uses of these properties will need null checks.
Changelog
🆑 FaintSpeaker