-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random Announcer System [PORT] #2652
base: master
Are you sure you want to change the base?
Random Announcer System [PORT] #2652
Conversation
hello! thanks for porting a feature from imp! it's an honor! couple notes on our announcers
|
Reason the PR is open is that it works on my machine, and I'm able to test. It's still kinda broken. Here's some takeaways from playing with it for a little while;
I think I'll do that in future PRs, and not all at once, so that when you or if you need to revert this you can do it sequentially (announcer by announcer) instead of having to like excise the announcers added here from the repo |
…o the template in case anyone ever wants an announcement for that.)
Other than Build and Test throwing a fit about the xeno vent critters localization pointing to {$location}, and also the lack of sound attribution (yes I do know - it's coming,) this is basically ready for actual review now. |
About the PR
Lord Deltanedas is gonna scream at me for this one because FUCK!! IT IS A MESS!!
This PR is for the Random Announcer System that EE has, originally from Parkstation. It is picked from Impstation who has fixed it up, so therefore a good amount of things are labeled as being from that.
To demonstrate this functionality, N.E.I.L. (Neil Breen, the ancient pre-rebase announcer voice) has been added back.
This touches a lot of upstream files and may be hell to maintain. It makes announcements a boolean, and makes using yaml to create announcers + add them to events maybe even a little easier.
I'm planning on adding announcers from Impstation (Sinister, Vox Mesa,) and other ones that eventually may crop up (The obama one that Lyndo keeps shitposting to me about, and Miku / Kasane Teto are some ideas that can be floated) in seperate sequential PRs, for ease of access if anyone would like to revert them.
Why / Balance
I have been a proponent of this for a long time; it adds more flexibility and customization to the server, and selects the voice that all the announcements are in at roundstart. It's cool, and more announcers = more fun, to me. There's little balance reason to it, it's just cool to have.
Technical details
Touches a load of C#, audio, events yaml, if there's an announcement, you name it, it touches it. Like, okay. In order of the tag labels:
Media
TODO; coming soon when I have this PR finally finished and ready for direction review (we are not to that point yet.)
Requirements
Breaking changes
Review notes for the maintainers that look at this - this shit needs a bunch of comments. Point out where I should put them, please. I mean it because this is a frankly fucking massive PR.
Otherwise, here's the most notable breaking change: this is going to break nearly all upstream files with a string for the announcement being said for that event; there are examples of booleans in the files changed you can replace these with (implying you can even load that.)
Changelog
🆑 Monotheonist, Einstein Engines, Impstation