Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better winter boots #2618

Closed

Conversation

HTMLSystem
Copy link
Contributor

About the PR

I resprited all winter boots that had the black outlines (so all winter boots in the DeltaV folder besides the security ones) to look better.

Why / Balance

Because the old sprites looked bad and I wanted to make them look better.

Technical details

Replaced all the sprites and added "...modified by HTMLSystem" in all meta.json files of the sprites I edited.

Media

better winter boots icons
better winter boots botany better winter boots CMO
Better winter boots HoP better winter boots mime
(I was going to get a screenshot of all of them but uh. No.)

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • tweak: Resprited a majority of winter boots, mostly all command and job-specific winter boots!

@HTMLSystem HTMLSystem requested a review from a team as a code owner January 5, 2025 00:32
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 5, 2025
Copy link
Contributor

github-actions bot commented Jan 5, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added S: Needs Review size/XS Under 16 lines Changes: Sprite Changes any png or json in an rsi and removed size/XS Under 16 lines labels Jan 5, 2025
Copy link
Contributor

github-actions bot commented Jan 5, 2025

RSI Diff Bot; head commit 4377c25 merging into 9a33cd0
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsatmos.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootscap.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsce.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootscentcom.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootschef.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootschem.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsclown.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootscmo.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsgen.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootshop.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootshydro.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsjani.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsmime.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsminer.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsparamed.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsqm.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsrd.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsrobo.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsviro.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootswarden.rsi

State Old New Status
equipped-FEET Modified
icon Modified
inhand-left Modified
inhand-right Modified

@HTMLSystem
Copy link
Contributor Author

This was my first time using an IDE for a PR, so hopefully nothing is wonky. I see there's a merge conflict so I will fix that after I vacuum and do other things yeah 👍

@deltanedas
Copy link
Member

just move everything to _DV and replace the references in yml

@HTMLSystem
Copy link
Contributor Author

Yeah this is gonna be a minute

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!!

@HTMLSystem HTMLSystem closed this Jan 15, 2025
@HTMLSystem HTMLSystem force-pushed the Better-command-winter-boots branch from 4377c25 to f3d2632 Compare January 15, 2025 03:55
@github-actions github-actions bot added the size/XS Under 16 lines label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi S: Merge Conflict Fix your PR! S: Needs Review size/XS Under 16 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants