refine error handling #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types ZKWAS-235: proof submit mode types
* add batch proof types * add initial types and query api * paginated result * update types for metadata + auto submit * refine type * export * fix enum export
* add prooftracker/batchverify * export * update * debug * try flatten * send tx * update types * update type for batchverify, update key names * fix exports
* update readme and interfaces * readme * rm dupe
* update types * add chain id to query * auto submit networks in config * metadata type for batch data
* rework metadata into fields * image interface update * update
* update readme * update
Merge auto sumbit feature into main for helper
* add reduced task * add user addr * separate endpoint * rename
add import assertions to mjs
Fix the issue that react cannot use import <JSON> from <json file> assert { type: json}
It is because after node version 17, node force the type checking if import is for json file directly.
So if we start node serivce via node command directly, we need add this "assert assert { type: json}" feature
React is still using old node version and react in fact do not care whether we have it or not.
However, we are using typescript.
Typescripts only suppor this new feature after 5.x version
React's react-scripts module haven't support 5.x version.
So we cannot change to use new 5.x version.
So we change to string.
* stats update * query update * endpoint name * fix type
* update load file for nodejs env * use buffer * try with md5 from uint8array * fix sig with initial context * add examples and update readme
* update type names * remove * naming updates * fix verify addr
* ZKWAS-301 & ZKWAS-304: Update inteface for node list improvements (#86) * ZKWAS-318: added endpoint for setting rest server maintenance mode (#88) --------- Co-authored-by: Oscar Downing <[email protected]>
yymone
reviewed
Aug 13, 2024
| @@ -28,9 +28,6 @@ export class ZkWasmServiceEndpoint { | |||
| ); | |||
| return response.data; | |||
| } catch (e: any) { | |||
| if (this.enable_logs) { | |||
There was a problem hiding this comment.
if internal log affect user, I suggest change the default of enable_logs to false instead of remove them.
This is debug purpose so we can just set enable_logs to false when create the ZkWasmServiceEndpoint.
But as we internally use it so client's may not be able to turn off it.
Thus I suggest change the default to false.
There was a problem hiding this comment.
Also need change the enable_logs default in ZkWasmServiceHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit removes the backtrace. This is the result of
bash publish.sh: