This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a thought, it might be nice to be able to specify closed PRs to run.ts? Currently you can specify a draft PR and run.ts will trigger the bot on it, however if you specify a closed PR run.ts silently terminates (
shouldRunOn()
is always false).This PR skips the all-open-prs query if PRs were specified and triggers the bot on them, open or otherwise.
Like in #352 I added the PR number to the projectboard-cards query, dropped the card ID from the all-open-prs query, and exclude all-open-prs from projectboard-cards on PR number vs. card ID, however in this case it's just to make the code a little tidier. Otherwise I'd need to initialize
cardIDs
toundefined
if PRs were specified, and assertcardIDs!
if not.