Speed up entry creation #422

DanielAmah · 2018-08-26T10:32:35Z

PR Description

This PR ensures that entries are created quickly by persisting the last entry on the form.

Issue

houndci-bot · 2018-08-26T10:32:45Z

app/views/application/_mileages_entry_form.html.haml

-  = f.association :project, required: true, collection: Project.unarchived.by_name, label: false, placeholder: t("entries.index.project")
-  = f.input :value, required: true, as: :integer, label:false, placeholder: t("entries.index.mileages")
+  = f.association :project, required: true, collection: Project.unarchived.by_name, label: false, placeholder: t("entries.index.project"), selected: (@last_mileage_logged.project_id if @last_mileage_logged )
+  = f.input :value, required: true, as: :integer, label:false, placeholder: t("entries.index.mileages"), input_html: { value: (@last_mileage_logged.value if @last_mileage_logged) }


Avoid using instance variables in partials views
Line is too long. [180/80]

houndci-bot · 2018-08-26T10:32:45Z

app/views/application/_mileages_entry_form.html.haml

@@ -1,6 +1,6 @@
 = simple_form_for @mileages_entry do |f|
  = f.error_notification
-  = f.association :project, required: true, collection: Project.unarchived.by_name, label: false, placeholder: t("entries.index.project")
-  = f.input :value, required: true, as: :integer, label:false, placeholder: t("entries.index.mileages")
+  = f.association :project, required: true, collection: Project.unarchived.by_name, label: false, placeholder: t("entries.index.project"), selected: (@last_mileage_logged.project_id if @last_mileage_logged )


Avoid using instance variables in partials views
Line is too long. [207/80]

houndci-bot · 2018-08-26T10:32:46Z

app/views/application/_hours_entry_form.html.haml

  = f.input :date, required: true, as: :string, input_html: { value: (@hours_entry.date || DateTime.current).strftime("%d/%m/%Y"), class: "datepicker"}, label: false
  .taggable
-    = f.input :description, input_html: { data: { data: Tag.list }, autocomplete: :off }, label: false, autocomplete: "off", placeholder: t("entries.index.description")
+    = f.input :description, input_html: { data: { data: Tag.list }, autocomplete: :off }, input_html: {value: (@last_hour_logged.description if @last_hour_logged)}, label: false, autocomplete: "off", placeholder: t("entries.index.description")


Avoid using instance variables in partials views
Line is too long. [243/80]

houndci-bot · 2018-08-26T10:32:46Z

app/views/application/_hours_entry_form.html.haml

-  = f.input :value, required: true, label: false, placeholder: t("entries.index.hours")
+  = f.association :project, required: true, collection: Project.unarchived.by_name, label: false, placeholder: t("entries.index.project"), selected: (@last_hour_logged.project_id if @last_hour_logged)
+  = f.association :category, required: true, collection: Category.by_name, label: false, placeholder: t("entries.index.category"), selected: (@last_hour_logged.category_id if @last_hour_logged)
+  = f.input :value, required: true, label: false, placeholder: t("entries.index.hours"), input_html: {value: (@last_hour_logged.value if @last_hour_logged)}


Avoid using instance variables in partials views
Line is too long. [156/80]

houndci-bot · 2018-08-26T10:32:46Z

app/views/application/_hours_entry_form.html.haml

-  = f.association :category, required: true, collection: Category.by_name, label: false, placeholder: t("entries.index.category")
-  = f.input :value, required: true, label: false, placeholder: t("entries.index.hours")
+  = f.association :project, required: true, collection: Project.unarchived.by_name, label: false, placeholder: t("entries.index.project"), selected: (@last_hour_logged.project_id if @last_hour_logged)
+  = f.association :category, required: true, collection: Category.by_name, label: false, placeholder: t("entries.index.category"), selected: (@last_hour_logged.category_id if @last_hour_logged)


Avoid using instance variables in partials views
Line is too long. [193/80]

houndci-bot · 2018-08-26T10:32:46Z

app/views/application/_hours_entry_form.html.haml

-  = f.association :project, required: true, collection: Project.unarchived.by_name, label: false, placeholder: t("entries.index.project")
-  = f.association :category, required: true, collection: Category.by_name, label: false, placeholder: t("entries.index.category")
-  = f.input :value, required: true, label: false, placeholder: t("entries.index.hours")
+  = f.association :project, required: true, collection: Project.unarchived.by_name, label: false, placeholder: t("entries.index.project"), selected: (@last_hour_logged.project_id if @last_hour_logged)


Avoid using instance variables in partials views
Line is too long. [200/80]

tarzan

I think the current approach would just break when the number of users start to grow...

tarzan · 2018-08-27T12:52:13Z

app/controllers/hours_controller.rb

@@ -21,6 +21,7 @@ def update
  def edit
    super
    resource
+    @last_hour_logged = Hour.last


A problem arises when multiple users add entries at the same time, you might end up with a form prefilled with your colleagues project. I think you might want to add a reference to the created entry on the redirect and use that to prefill the form....

Thanks, @tarzan I will look into it.

Hi @tarzan, concerning this task, instead of passing in the Hour.last or Mileage.last, I decided to pass in current_user.hours.last which is last hour entry by that user. So this ensures that the hours displayed is that of the current user when the user wants to fill up the entry or mileage form. Adding a reference to the created entry on the redirect may not give us the behaviour we want because that value is only available when a user creates the entry when the user signout and returns back later, the user may not see the values prefilled.
Those
this sound good?

…n the form

DanielAmah · 2018-09-03T17:44:36Z

Thanks for the feedback @tarzan. It is really good. But I came up with another idea. Instead of injecting the created record into the redirect, we could instead, get the last hour for the current user. We could pass in current_user.hours.last to prefilled the hours' form and current_user.mileages.last to prefilled the mileages form. With this approach, even when the user logged out and comes back after some time, the form would still be prefilled with the last saved entry. I hope that sounds good.

jattoabdul · 2019-04-17T23:10:35Z

app/controllers/hours_controller.rb

@@ -21,6 +21,7 @@ def update
  def edit
    super
    resource
+    @last_hour_logged = current_user.hours.last


Don't you think that this means that when a user selects a particular entry(hour) to edit, instead of prefilling the selected one, the last hour is selected, which might not be the same as what was selected?.

jattoabdul · 2019-04-17T23:11:30Z

app/controllers/mileages_controller.rb

@@ -24,6 +24,7 @@ def update
  def edit
    super
    resource
+    @last_mileage_logged = current_user.mileages.last


https://github.com/DefactoSoftware/Hours/pull/422/files#r276466822
Same as comment above 👆🏽

jurre · 2020-01-30T15:04:10Z

We've decided to freeze feature development as none of the maintainers currently have time to properly steward contributions from the community.

houndci-bot reviewed Aug 26, 2018

View reviewed changes

tarzan requested changes Aug 27, 2018

View reviewed changes

this ensures that entries made quickly by persisting the last entry o…

9bedf1c

…n the form

DanielAmah force-pushed the speed-up-entry-creation branch from 5c1d35b to 9bedf1c Compare September 3, 2018 17:38

jattoabdul reviewed Apr 17, 2019

View reviewed changes

jurre closed this Jan 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Speed up entry creation #422

Speed up entry creation #422

DanielAmah commented Aug 26, 2018

houndci-bot Aug 26, 2018

houndci-bot Aug 26, 2018

houndci-bot Aug 26, 2018

houndci-bot Aug 26, 2018

houndci-bot Aug 26, 2018

houndci-bot Aug 26, 2018

tarzan left a comment

tarzan Aug 27, 2018

dnlamah Sep 1, 2018 •

edited

Loading

DanielAmah Sep 3, 2018

DanielAmah commented Sep 3, 2018 •

edited

Loading

jattoabdul Apr 17, 2019

jattoabdul Apr 17, 2019

jurre commented Jan 30, 2020

Speed up entry creation #422

Speed up entry creation #422

Conversation

DanielAmah commented Aug 26, 2018

PR Description

Issue

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarzan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnlamah Sep 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanielAmah commented Sep 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jurre commented Jan 30, 2020

dnlamah Sep 1, 2018 •

edited

Loading

DanielAmah commented Sep 3, 2018 •

edited

Loading