[wip] Adding creditcard payment #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| require 'rails_helper' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Yes and yes |
| @user_count ||= User.count | ||
| end | ||
| end | ||
|
|
fatboypunk
force-pushed
the
marcel/stripe
branch
from
74d71a7 to
1485436
Compare
fatboypunk
force-pushed
the
marcel/stripe
branch
from
1485436 to
88824bc
Compare
| email: current_user.email, | ||
| quantity: user_count | ||
| ) | ||
| pp customer.instance_methods(false) |
There was a problem hiding this comment.
Do not write to stdout. Use Rails' logger if you want to log.
fatboypunk
force-pushed
the
marcel/stripe
branch
from
40c248d to
cd78851
Compare
| end | ||
|
|
||
| def costs | ||
| enabled? ? @number_of_users * price : 0 |
| sign_in_user(user, subdomain: subdomain) | ||
|
|
||
| visit users_url(subdomain: subdomain) | ||
| expect(page).not_to have_selector("input[type=submit][value='#{I18n.t("users.de_activate")}']") |
There was a problem hiding this comment.
Line is too long. [101/80]
Prefer single-quoted strings inside interpolations.
fatboypunk
force-pushed
the
marcel/stripe
branch
2 times, most recently
from
bb55534 to
cb280d4
Compare
| @@ -44,7 +9,7 @@ class User < ActiveRecord::Base | |||
| :confirmable, | |||
| :invitable | |||
|
|
|||
| validates_presence_of :first_name, :last_name | |||
| validates_presence_of :first_name, :last_name, :active | |||
There was a problem hiding this comment.
Prefer the new style validations validates :column, presence: value over validates_presence_of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to solve #35
removede-activate users