-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: simplify docker installation and improve the manual one #615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I am looking at the install instructions now.
We are basically asking people to clone the entire (fairly large) repo only to access the environment yml file and then pip install it from elsewhere. Given that we anyway have the installation commands copy/pastable, would it perhaps make sense to have a command to download just that one file instead? Or is it even possible to create the env from the online file?
Not sure if it's worthwhile changing, just noticed this and thought I'd mention it :)
Very good point! I changed them in d424a26, let me know if you like it better now :) |
Nice! Also, requirements-docker.txt can be removed from the bumpversion config file. |
I removed the ref in that part, thanks :)
Good catch, removed! |
No description provided.