Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: simplify docker installation and improve the manual one #615

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

gcroci2
Copy link
Collaborator

@gcroci2 gcroci2 commented Jun 20, 2024

No description provided.

@gcroci2 gcroci2 requested a review from DaniBodor June 20, 2024 14:15
@gcroci2 gcroci2 linked an issue Jun 20, 2024 that may be closed by this pull request
6 tasks
@gcroci2 gcroci2 changed the base branch from main to dev June 20, 2024 14:16
Copy link
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I am looking at the install instructions now.
We are basically asking people to clone the entire (fairly large) repo only to access the environment yml file and then pip install it from elsewhere. Given that we anyway have the installation commands copy/pastable, would it perhaps make sense to have a command to download just that one file instead? Or is it even possible to create the env from the online file?

Not sure if it's worthwhile changing, just noticed this and thought I'd mention it :)

@gcroci2
Copy link
Collaborator Author

gcroci2 commented Jun 21, 2024

So, I am looking at the install instructions now. We are basically asking people to clone the entire (fairly large) repo only to access the environment yml file and then pip install it from elsewhere. Given that we anyway have the installation commands copy/pastable, would it perhaps make sense to have a command to download just that one file instead? Or is it even possible to create the env from the online file?

Not sure if it's worthwhile changing, just noticed this and thought I'd mention it :)

Very good point! I changed them in d424a26, let me know if you like it better now :)

@gcroci2 gcroci2 changed the title docker: simply the installation of the environment in the DockerFile build: simply docker installation and improve the manual one Jun 21, 2024
@gcroci2 gcroci2 requested a review from DaniBodor June 21, 2024 14:06
@DaniBodor
Copy link
Collaborator

DaniBodor commented Jun 24, 2024

So, I am looking at the install instructions now. We are basically asking people to clone the entire (fairly large) repo only to access the environment yml file and then pip install it from elsewhere. Given that we anyway have the installation commands copy/pastable, would it perhaps make sense to have a command to download just that one file instead? Or is it even possible to create the env from the online file?
Not sure if it's worthwhile changing, just noticed this and thought I'd mention it :)

Very good point! I changed them in d424a26, let me know if you like it better now :)

Nice!
I guess the other thing is that if it wasn't cloned, the tests won't work, so the testing part should maybe be deleted or adjusted as well?

Also, requirements-docker.txt can be removed from the bumpversion config file.

@DaniBodor DaniBodor changed the title build: simply docker installation and improve the manual one build: simplify docker installation and improve the manual one Jun 25, 2024
@gcroci2
Copy link
Collaborator Author

gcroci2 commented Jul 1, 2024

Nice! I guess the other thing is that if it wasn't cloned, the tests won't work, so the testing part should maybe be deleted or adjusted as well?

I removed the ref in that part, thanks :)

Also, requirements-docker.txt can be removed from the bumpversion config file.

Good catch, removed!

@gcroci2 gcroci2 merged commit c7513c6 into dev Jul 1, 2024
6 checks passed
@gcroci2 gcroci2 deleted the docker_cleaning_gcroci2 branch July 1, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda migration
2 participants