-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: switch to conda dssp installation #549
Conversation
merge with main
docs: add `Dockerfile` and `.yml` for building conda env
docs: implement minor suggestions for JOSS paper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I tested all 3 installation procedures (docker, env file, manual) and they all work!
I added 2 commits to this branch.
- The first one is some automatic formatting updates. I think maybe you don't have the prettier extension installed, so then vs code cannot automatically format the files that use that (most non-python files).
- Suggestions to the README.
I thought it'd be easier to just put everything in a single commit, rather than add a bunch of code suggestions. Feel free to drop either if you don't like it or to adjust as you prefer.
Note that the python 3.11 issue isn't (stably) fixed after all, so please do not close that issue with this PR.
Finally, the newest version of pandas is giving a warning. Maybe we should add Pyarrow to the deeprank dependencies to make it future proof (and avoid the warning).
/tmp/ipykernel_32/1088082951.py:2: DeprecationWarning:
Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
(to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
but was not found to be installed on your system.
If this would cause problems for you,
please provide us feedback at pandas-dev/pandas#54466import pandas as pd
Oh right, I installed it now :)
Very nice edits, thanks! I'll leave the commit, I only corrected two typos and edited a couple of subtitles.
I removed it from my initial comment indeed. What if I remove Python 3.11 from the CI for now? In a few weeks we can try to pick up the issue again, check it better, and see if anything has changed. But at least we will publish a "real" stable version that works on Python 3.10. I have added a commit for this, let me know what you think. If you agree, I will also add a comment to issue #540. @DaniBodor
I think they will add it themselves when installing pandas (as a pandas dependency in their config/toml file). The warning should be to gather feedback on this possibility shortly so that they know if adding this dependency will cause an issue for anyone. But I wouldn't worry about it, it will be installed automatically by pandas when the time comes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed an indent level error in the installation.md file (which I probably created when copy/pasting from the README).
Perfect. I agree with all of this. |
Co-authored-by: Dani Bodor <[email protected]>
Co-authored-by: Dani Bodor <[email protected]>
With this PR,
dssp
package is installed through conda instead of source or apt-get. This is a usage improvement for the users and is a step forward for deploying deeprank2 on conda (see issue #559). In particular: