Fix path comparision to be OS independant #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanWay
approved these changes
Jul 27, 2024
|
Good point. You would need to specify paths for windows and linux if you work on cross-platform. I'll check it again |
…tten unix or windows style and works cross-platform
|
I switched to path normalization. This will allow arbitrary path formats for any platform. I tested it on windows, but I have no UNIX on hand. @DeanWay: The PR is ready to merge. I don't have the rights to do so |
|
push |
|
this is released in 0.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love the idea of your tool, but it only works on unix system. This fix will have it work on windows as well