Skip to content
This repository has been archived by the owner on Oct 19, 2020. It is now read-only.

Feature/uri activity #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jukylin
Copy link

@jukylin jukylin commented Sep 28, 2017

No description provided.

@@ -1,7 +1,7 @@
JPush API Go Client
====================

[![GoDoc](https://godoc.org/github.com/DeanThompson/jpush-api-go-client?status.svg)](https://godoc.org/github.com/DeanThompson/jpush-api-go-client) [![Build Status](https://travis-ci.org/DeanThompson/jpush-api-go-client.svg?branch=master)](https://travis-ci.org/DeanThompson/jpush-api-go-client)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果要 merge 进来,请把文档地址恢复到 github.com/DeanThompson, 下同

@@ -4,7 +4,7 @@ import (
"fmt"
"net/http"

"github.com/DeanThompson/jpush-api-go-client/common"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请修复 import 地址,下同

@@ -44,6 +44,10 @@ type AndroidNotification struct {

Title string `json:"title,omitempty"`
BuilderId int `json:"builder_id,omitempty"`
Style int `json:"style,omitempty"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提交代码前请执行 gofmt

@@ -27,7 +27,7 @@ func (n *Notification) Validate() error {

// 平台通用的通知属性
type platformNotification struct {
Alert string `json:"alert"` // required
Alert interface{} `json:"alert"` // required
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改了 Alert 的类型,需要测试

}

func NewIosNotification(alert string) *IosNotification {
func NewIosNotification(alert map[string]string) *IosNotification {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改了函数签名,需要测试

*.exe
*.test
*.prof
api.push
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新增的 ignore 规则,请添加到末尾,保留原来的规则

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants